981353 - CppEclipse nspr indexer errors

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #980183 +++

This fixes a few more indexer errors.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8388149 [details] [diff] [review]
patch

Review of attachment 8388149 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +301,5 @@
>                                                  </entry>
>                                                  <!--
>                                                    Because of https://developer.mozilla.org/en-US/docs/Eclipse_CDT#Headers_are_only_parsed_once
>                                                    we need to make sure headers are parsed with MOZILLA_INTERNAL_API to make sure
>                                                    the indexer gets the version that is used in most of the true. This means that

Drive-by nit: "most of the true"

Comment 2

[Benoit Girard (:BenWa)]

(In reply to :Ms2ger from comment #1)

Fixed in the next patch in my queue.

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f3a63ff170d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f3a63ff170d