Closed Bug 981353 Opened 8 years ago Closed 8 years ago

CppEclipse nspr indexer errors

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: BenWa, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
+++ This bug was initially created as a clone of Bug #980183 +++

This fixes a few more indexer errors.
Attachment #8388149 - Flags: review?(botond)
Attachment #8388149 - Attachment is patch: true
Attachment #8388149 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8388149 [details] [diff] [review]
patch

Review of attachment 8388149 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +301,5 @@
>                                                  </entry>
>                                                  <!--
>                                                    Because of https://developer.mozilla.org/en-US/docs/Eclipse_CDT#Headers_are_only_parsed_once
>                                                    we need to make sure headers are parsed with MOZILLA_INTERNAL_API to make sure
>                                                    the indexer gets the version that is used in most of the true. This means that

Drive-by nit: "most of the true"
(In reply to :Ms2ger from comment #1)

Fixed in the next patch in my queue.
Blocks: 981411
Blocks: 981427
Attachment #8388149 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/5f3a63ff170d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.