98149 - Comments in SGML derived tags are not shown as such in view source

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect)

Description

[Markus Gerstel]

Go to the attachment and take a look at the source code. (CTRL+U)

According the HTML 4.01 specifications a comment looks like this :
<!-- Comment -- Here it's NOT a comment -- Comment again -->
This shows up for example in the DTD's :
<!ENTITY % HTML.Version "-//W3C//DTD HTML 4.01 Transitional//EN"
  -- Typical usage: etc.... etc... ... -->

However an ENTITY is entirely cyan, and a Comment is entirely green - even in
non-Comment and Comment-space.

This bug is trivial. It isn't even trivial, it's less than that. But it should
be noted somewhere. And should get fixed until Mozilla 2.0 =) if ever.

Comment 1

[Markus Gerstel]

Attachment: Testcase

Comment 2

[Andreas M. "Clarence" Schneider]

Attachment: screenshot of testcase with patch for bug 57724

Comment 3

[Andreas M. "Clarence" Schneider]

*** This bug has been marked as a duplicate of 57724 ***

Comment 4

[Markus Gerstel]

I'm impressed =)

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 6

[Christopher Hoess (gone)]

Reopening 57724 dependencies for independent resolution.

Comment 7

[Markus Gerstel]

AFAICR this has been fixed. But as for now I can't confirm it. Mozilla always
hangs when trying to view the testcase (filed as Bug 123723)

Comment 8

[Christopher Hoess (gone)]

->Parser, I think

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Tweaking summary to be more descriptive.

Comment 10

[Michael Newton]

I think this bug can't be fixed without parsing SGML comments correctly, which I
think can't be done.
Since the beginning of HTML it's been said that a comment start tag is <!-- and
a comment end tag is -->, which is not true of course, but it's what's been used.
So, for example, anyone who marks a section with this:
<!----------section header------------->
will most likely comment out the rest of their page, unless they've counted the
hyphens!  There are probably many situations where people have double hyphens
"in"  their comments.
Although it would be neat to be an SGML parser, I think the main purpose is to
be an HTML parser and, going forward, an XML parser.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Except for the fact that we do parse HTML comments as SGML says we should in
strict mode, how we parse HTML comments has very little to do with this bug,
which is about coloring comments in SGML productions (such as <!DOCTYPE>)
properly in view-source.

Comment 12

[Henri Sivonen (:hsivonen)]

Tracking HTML5 now for parsing. Not SGML.

See also http://ln.hixie.ch/?start=1137799947&count=1