981711 - [Messages][DSDS] Bug 947180 broke the SIM switch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

... moreover now we can find the correct serviceId from the message's iccId.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: github PR

I need to do a small change before requesting review.

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8389019 [details] [review]
github PR

    This patch restores the SIM switching functionality using the iccId property.

 apps/sms/js/settings.js              | 33 +++++++++++++++------------------
 apps/sms/js/thread_ui.js             | 30 ++++++++++++++++++------------
 apps/sms/test/unit/mock_settings.js  |  3 +--
 apps/sms/test/unit/settings_test.js  | 29 ++++++++++++++++++++++++++---
 apps/sms/test/unit/thread_ui_test.js | 10 +++++++++-
 5 files changed, 69 insertions(+), 36 deletions(-)

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8389019 [details] [review]
github PR

Thanks for discovering this serious bug and I should notice it in the previous patch... Only one issue about the message dom status and some nit for the tests.

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 8389019 [details] [review]
github PR

Pushed a new version with all follow-ups in a separate commit.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

hi Francisco, can you take the review from Steve? Steve is out on Mar 13~14
Thanks

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.4+ regresion

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8389019 [details] [review]
github PR

Just went through it and looks pretty nice as always.

Tried on the phone and working ok for me. Just did a couple of comments in the PR but they are minor comments.

Thanks Juliene

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8389019 [details] [review]
github PR

Pushed a new test as requested.

r?=francisco because Steve is away today. (but Steve, if you're around, you're welcome to review as well ;) )

Comment 10

[Steve Chung [:steveck]]

Comment on attachment 8389019 [details] [review]
github PR

r=me, thanks fir the fixing!

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8389019 [details] [review]
github PR

Thanks Steve !

Comment 12

[Julien Wajsberg [:julienw]]

master: f694e3a53d246ef11d59c18ac5d7c663941f5eb8