981825 - Handle reverting fake branch values in build-{running, pending}.js and builds-4hr.js.gz

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Zeller [:zeller]]

Fake branches are used to allow the triggering of arbitrary builds and tests (Bug 793989), because if a real value, like "mozilla-central", or "mozilla-central-opt-linux", is chosen then we risk triggering the regular schedulers and having a full suite of test runs scheduled instead of just the builder we're interested in. However, this causes tbpl not to show these jobs running because the first thing it does is look for jobs on-this-branch, and then on-this-rev. TBPL however does show the finished jobs because it picks them out of getRevisionBuilds.php.

Adjusting build-{running, pending}.js and builds-4hr.js.gz to revert the fake branch values should fix this issue. Fake branch values are simply branch names appended with -selfserve as shown here http://hg.mozilla.org/build/buildapi/file/0ab4da5551a8/buildapi/controllers/selfserve.py#l525

Comment 1

[Chris AtLee [:catlee]]

It's new rows in the changes table that are problematic. I think we should be able to use the real branch in the sourcestamp without ill effect.

Comment 2

[John Zeller [:zeller]]

(In reply to Chris AtLee [:catlee] from comment #1)
> It's new rows in the changes table that are problematic. I think we should
> be able to use the real branch in the sourcestamp without ill effect.

If I understand this correctly, are you saying that removing the fake branch names should be fine then?

Comment 3

[John Zeller [:zeller]]

Attachment: bug981825.patch

This should fix the problem as per catlee's advice from comment 1

Comment 4

[Hal Wine [:hwine] use NI!]

Comment on attachment 8392463 [details] [diff] [review]
bug981825.patch

https://hg.mozilla.org/build/buildapi/rev/a9494a6b26fb

Comment 5

[John Zeller [:zeller]]

The fix in bug 1009565 seems to have resolved anymore issues with this. TBPL is now showing pending and running arbitrary builds. Patch that seems to have fixed this issue is https://bug1009565.bugzilla.mozilla.org/attachment.cgi?id=8422070