Closed
Bug 981855
Opened 11 years ago
Closed 11 years ago
tps: can't find tab after sync
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Cloud Services Graveyard
Server: Sync
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edwong, Assigned: whimboo)
References
Details
1. install tps
2. run this:
runtps --testfile=/Users/Edwin/dev/services-central/services/sync/tests/tps/test_tabs.js --binary=/Applications/FirefoxNightly.app/Contents/MacOS/firefox
test calls:
Phase('phase2', [
[Sync],
[Tabs.verify, tabs1],
[Tabs.add, tabs2],
[Sync]
]);
which calls:
case ACTION_VERIFY:
Logger.AssertTrue(typeof(tab.profile) != "undefined",
"profile must be defined when verifying tabs");
Logger.AssertTrue(
BrowserTabs.Find(tab.uri, tab.title, tab.profile), "error locating tab");
break;
case ACTION_VERIFY_NOT:
Logger.AssertTrue(typeof(tab.profile) != "undefined",
"profile must be defined when verifying tabs");
Logger.AssertTrue(
!BrowserTabs.Find(tab.uri, tab.title, tab.profile),
"tab found which was expected to be absent");
break;
default:
Logger.AssertTrue(false, "invalid action: " + action);
actual:
CROSSWEAVE INFO: starting action: [null,[{"uri":"http://hg.mozilla.org/automation/crossweave/raw-file/2d9aca9585b6/pages/page3.html","title":"Crossweave Test Page 3","profile":"profile2"},{"uri":"data:text/html,<html><head><title>Bye</title></head><body>Bye</body></html>","profile":"profile2"}]]
CROSSWEAVE INFO: executing action VERIFY on tab {"uri":"http://hg.mozilla.org/automation/crossweave/raw-file/2d9aca9585b6/pages/page3.html","title":"Crossweave Test Page 3","profile":"profile2"}
CROSSWEAVE ERROR: [phase3] Exception caught: ASSERTION FAILED! error locating tab No traceback available
WARNING: A completion condition encountered an error while we were spinning the event loop. Condition: OS.File: flush pending requests, warn about unclosed files, shut down service. Phase: web-workers-shutdown State: (none)
WARNING: Error: OS.File has been shut down.
WARNING: Scheduler.push/promise<@resource://gre/modules/osfile/osfile_async_front.jsm:206:9
Handler.prototype.process@resource://gre/modules/Promise.jsm:782:11
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:661:7
Spinner.prototype.observe@resource://gre/modules/AsyncShutdown.jsm:446:7
|
Reporter | |
Comment 1•11 years ago
|
||
This is a regression for sync 1.1
:rnewman - any ideas on where to start investigating. My own manual testing also indicates tab sync is flaky.
Flags: needinfo?(rnewman)
|
||
Comment 2•11 years ago
|
||
about:sync-tabs pokes around at a lower level in order to trigger a tabs-only sync. If the identity isn't ready, that probably won't work. I don't know what would be wrong with TPS.
Flags: needinfo?(rnewman)
|
Assignee | |
Comment 3•11 years ago
|
||
My upcoming refactoring patch on bug 966434 will not fix that. When we start the test, we are logged in. So something else is causing this.
|
||
Updated•11 years ago
|
Assignee: nobody → andreea.matei
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
When I put [Tabs.verify, tabs2] into phase 2 after adding the tabs, it also fails. So we might not have a problem with sync but with tps and how it handles tabs. A minimized test might be good to have.
|
|
Assignee | |
Comment 5•11 years ago
|
||
This should have been fixed by my patch on bug 981848. Edwin, can you please verify?
Assignee: andreea.matei → hskupin
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•