Closed Bug 982080 Opened 7 years ago Closed 7 years ago

[Contacts] JSHint fixes for js/utilities

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S4 (28mar)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: kgrandon, Assigned: arcturus)

References

Details

Attachments

(1 file)

We would like to have these files passing JSHint.
Blocks: 982081
No longer blocks: 982081
Assignee: nobody → francisco.jordano
Attached file Pointer to PR 17101
Waiting for travis results
Attachment #8389514 - Flags: review?(jmcf)
Attachment #8389514 - Flags: feedback?(kgrandon)
I'm quite ashamed we didn't do this before.

I just realised we had some variables in code not being used, and parts of the code that would never have been executed with typos :S
Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

(In reply to Francisco Jordano [:arcturus] from comment #2)
> I just realised we had some variables in code not being used, and parts of
> the code that would never have been executed with typos :S

Yup - I noticed a few of these in the unit/marionette tests as well. I'm sure we'll find many more :)
Attachment #8389514 - Flags: feedback?(kgrandon) → feedback+
Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

as stated in GH there is a change that breaks worker-based sync.

other issues are related to not using the /* exported */ directive

thanks!
Attachment #8389514 - Flags: review?(jmcf) → review-
Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

Suggestions applied.

Thanks for taking a look.
Attachment #8389514 - Flags: review- → review?(jmcf)
Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

there is a missed exported directive. Please check and once Travis is green
 land

thanks!
Attachment #8389514 - Flags: review?(jmcf) → review+
Thanks for catching it!
Landed:

https://github.com/mozilla-b2g/gaia/commit/e82b6a9eb023aa04d9ecd47bce2eb137f069ca89
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in before you can comment on or make changes to this bug.