982080 - [Contacts] JSHint fixes for js/utilities

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Kevin Grandon :kgrandon]

We would like to have these files passing JSHint.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 17101

Waiting for travis results

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

I'm quite ashamed we didn't do this before.

I just realised we had some variables in code not being used, and parts of the code that would never have been executed with typos :S

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

(In reply to Francisco Jordano [:arcturus] from comment #2)
> I just realised we had some variables in code not being used, and parts of
> the code that would never have been executed with typos :S

Yup - I noticed a few of these in the unit/marionette tests as well. I'm sure we'll find many more :)

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

as stated in GH there is a change that breaks worker-based sync.

other issues are related to not using the /* exported */ directive

thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

Suggestions applied.

Thanks for taking a look.

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8389514 [details] [review]
Pointer to PR 17101

there is a missed exported directive. Please check and once Travis is green
 land

thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Thanks for catching it!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/e82b6a9eb023aa04d9ecd47bce2eb137f069ca89