Closed
Bug 982081
Opened 11 years ago
Closed 11 years ago
[Contacts] JSHint fixes for js/views
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
We would like to have these files passing JSHint.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
This is still in progress. I may wait for my patch on bug 987282 that solves the getter without setter problem before finishing this.
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8395945 [details] [review]
Github pull request
Hi Francisco - please take a look when you have a chance. Thanks!
Attachment #8395945 -
Flags: review?(francisco.jordano)
Comment 3•11 years ago
|
||
Comment on attachment 8395945 [details] [review]
Github pull request
Couldn't try on the phone cause it needs a rebase, but all the changes are looking good.
Thanks a lot Kevin!
Attachment #8395945 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•