Closed
Bug 982126
Opened 11 years ago
Closed 11 years ago
[NFC] Set session ID in NFC messages
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S3 (14mar)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
|
1020 bytes,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
The session id in NFC messages is missing. The related error messages look like
> I/Gecko ( 46): Nfc Worker: Received DOM message {"requestId":"aWR7NWY0NDU0NzUtMWVjNS00YjNlLThmOTMtOWFjODljNTQzMjIwfQ==","sessionToken":"{959a7d96-b55b-4b53-9545-1d258a99f1f2}","techType":10,"type":"connect"}
> I/Gecko ( 46): Nfc Worker: New outgoing parcel of type 1
> I/Gecko ( 46): -*- Nfc: Received 'NFC:Connect' message from content process
> I/Gecko ( 46): Nfc Worker: Outgoing parcel: 0,0,0,12,1,0,0,0,0,0,0,0,10,0,0,0
> E/GeckoConsole( 46): [JavaScript Warning: "ReferenceError: reference to undefined property message.sessionId" {file: "resource://gre/modules/nfc_worker.js" line: 289}]
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8389209 -
Flags: review?(allstars.chh)
Comment on attachment 8389209 [details] [diff] [review]
[01] Bug 982126: Set session ID in NFC messages
Review of attachment 8389209 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch, sorry I didn't notice this error before.
Attachment #8389209 -
Flags: review?(allstars.chh) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
No problem, thanks for the quick review.
https://hg.mozilla.org/integration/b2g-inbound/rev/ebe5eb5b8d2a
https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=ebe5eb5b8d2a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•