Closed Bug 982640 Opened 6 years ago Closed 6 years ago
Port GTK2 to GTK3 - transparent widgets
There are more transparent widgets in Gtk3 - scroll bars and toolbars.
Downstream bug - https://bugzilla.redhat.com/show_bug.cgi?id=1054982
I don't know that it makes sense to make a scrollbar trough transparent. If we need to make it transparent to make it look right, then something must be drawing behind it, but what is that? If a scrollbar is drawn for a scrollable div in a document, then I assume it gets the background from the ancestor elements in the document, which I assume is not the background expected? Further it looks like Adwaita has an opaque linear gradient for the trough background, and GTK's default theme has a solid color, so which theme has transparent scrollbar troughs? https://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-3.0/gtk-widgets-backgrounds.css?id=3.8.4#n26
Is the issue that the gradient is only drawn as far as the radial borders? What is the appropriate background outside those borders? Would it be the document? I don't understand what "@borders" means in the linear-gradient notation. background-image: linear-gradient(to bottom, @borders, shade(@theme_bg_color, 0.95) );
Comment on attachment 8389807 [details] [diff] [review] patch This is probably good, if you change the checkin comment to say what is changing and are happy with other content showing through the transparent bits.
Attachment #8389807 - Flags: review?(karlt) → review+
Thanks! The patch forces gecko to don't rely on widgets own background and always paint underlying widget, which is usually GtkWindow.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.