GTK3 - ensure that we build with system-cairo

RESOLVED FIXED in mozilla30

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: stransky, Assigned: stransky)

Tracking

Trunk
mozilla30
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

cairo-gtk3 can't be build with in-tree cairo, let's check that in configure script.
Set system-cairo as default for gtk3 target and fails when user overrides it. Ted, can you check this one please?
Attachment #8389873 - Flags: review?(ted)
Out of 'idle' curiosity, does firefox built against gtk3 still has the problem described in bug 862422 ?

As of firefox 27 and gtk2, it's still a present problem.
(In reply to Rafał Mużyło from comment #2)
> Out of 'idle' curiosity, does firefox built against gtk3 still has the
> problem described in bug 862422 ?
> 
> As of firefox 27 and gtk2, it's still a present problem.

I don't think there's a difference in Gtk3 version so I expect the same problems here.
(In reply to Martin Stránský from comment #3)
> (In reply to Rafał Mużyło from comment #2)
> > Out of 'idle' curiosity, does firefox built against gtk3 still has the
> > problem described in bug 862422 ?
> > 
> > As of firefox 27 and gtk2, it's still a present problem.
> 
> I don't think there's a difference in Gtk3 version so I expect the same
> problems here.

In such case, any chance on *you* reopening it and adding it to the 'porting to gtk3' tracker ?
Cause if I'd do it, it would likely just get VERIFIED.
Comment on attachment 8389873 [details] [diff] [review]
cairo check patch

Review of attachment 8389873 [details] [diff] [review]:
-----------------------------------------------------------------

What's the problem with the in-tree cairo, does it just need an update to handle gtk3? (Is there a bug on that?)
Attachment #8389873 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> Comment on attachment 8389873 [details] [diff] [review]
> cairo check patch
> 
> Review of attachment 8389873 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What's the problem with the in-tree cairo, does it just need an update to
> handle gtk3? (Is there a bug on that?)

Thanks! There's a problem with system cairo, it causes flash plugin flickering. In-tree cairo works as expected.
Keywords: checkin-needed
Did you mean that the other way around? Your patch implements the opposite.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> Did you mean that the other way around? Your patch implements the opposite.

I know, it's because Gtk3 can't be build with in-tree cairo, the system one has to be used. IMO the flash flickering has to be fixed in cairo package shipped by linux distros.
(In reply to Martin Stránský from comment #8)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> > Did you mean that the other way around? Your patch implements the opposite.
> 
> I know, it's because Gtk3 can't be build with in-tree cairo, the system one
> has to be used. IMO the flash flickering has to be fixed in cairo package
> shipped by linux distros.

Are you sure this flickering isn't a bug in firefox ?
cairo 1.12 has been around for quite awhile already.
As I said, if system cairo should be mandatory for gtk3, bug 862422 should be revisited and potentially reopened.
https://hg.mozilla.org/mozilla-central/rev/ac77c843076f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Blocks: 1034064
No longer blocks: 1034064
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.