982708 - [NFC] Output RF discovery id in emulator console

Status: RESOLVED INVALID

(Firefox OS Graveyard :: NFC, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We need the RF discovery id to select the connection when talking to the NFC emulator.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request (v2)

If you test this patch and run into bug 970263, you can work around it by manually enabling NFC in the Settings app before running the tests.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8389887 [details]
Github pull request (v2)

Looks good to me, but I haven't had a try yet.  Will do asap.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8389887 [details]
Github pull request (v2)

This patch fails command "nfc ntf rf_intf_activated".

  emulator64-arm: external/qemu/hw/nfc-nci.c:1007: nfc_create_rf_intf_activated_ntf: Assertion `*re' failed.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

If don't bother very much, please attach an test script for testing supported nfc console commands.  Currently we have only "nfc ntf rf_intf_activated <n>" referenced in https://mxr.mozilla.org/mozilla-central/source/dom/nfc/tests/marionette/test_nfc_manager_tech_discovered.js , but there are also:

  nfc ntf rf_discover <i>
  nfc ntf rf_intf_activated [<i>]
  nfc data s|send|w|wr|write <connid> <data>

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8389887 [details]
Github pull request (v2)

I pushed an updated version into the pull request.

Changes since v1:

  - added proper error messages
  - reworked console interface to catch more errors earlier...
  - ...including !re->active_re

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Vicamo

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> If don't bother very much, please attach an test script for testing
> supported nfc console commands.  Currently we have only "nfc ntf
> rf_intf_activated <n>" referenced in
> https://mxr.mozilla.org/mozilla-central/source/dom/nfc/tests/marionette/
> test_nfc_manager_tech_discovered.js , but there are also:
> 
>   nfc ntf rf_discover <i>

This command makes the emulator 'discover' device no <i>. I implemented this once, but it broke at some point. I opened bug 984337 to track the issue.

>   nfc ntf rf_intf_activated [<i>]

I guess you mean rf_intf_activated without any parameter. This depends on rf_discover. If an NFC device has been discovered in the vicinity, it can be selected as 'active' by the NFC driver. Running rf_intf_activated without parameters should activate the selected interface for data transmission.

>   nfc data s|send|w|wr|write <connid> <data>

This is tracked in bug 980851.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8389887 [details]
Github pull request (v2)

Removing the r? for now. I need to re-evaluate if this change is necessary.

Comment 8

[Ken Chang[:kenkai]]

This bug blocks NFC 2.0 release.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I figured out that the internal id is not necessary. So this bug report is invalid.