970263 - B2G NFC: Enable NFC when running NFC marionette tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Right now if the screen is off or locked, NFC daemon will enter lower power mode(Disable discovery).

So when running marionette test for NFC, we should also unlock the lockScreen and keeps screen always on.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Also see the assertion from https://bugzilla.mozilla.org/show_bug.cgi?id=976478#c0

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Yoshi,

I was debugging this problem today.

A change to the settings value 'nfc.enabled' should be observed by nfc_manager.js near line 144. When doing the test steps by hand, I see the event twice, once during boot, and a second time when I enable NFC in the Settings app. But when I run the test case, I only see this event at the beginning; not during the test itself. Any ideas?

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I also know this and is checking this too.

It seems before the marionette starts, some Gaia app (communication) has been killed,
and the system app is also gone, so nfc_manager cannot observe the settings change event from head.js.

One thing I also found that is System app is running on b2g process, so the process shouldn't be killed, however it is gone.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This might be related to bug 777840.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 7

[Dimi Lee [:dimi]]

Comment on attachment 8405270 [details] [diff] [review]
Patch.

Review of attachment 8405270 [details] [diff] [review]:
-----------------------------------------------------------------

If we will not use setting in test cases maybe we could remove 
SpecialPowers.pushPermissions(
  [{'type': 'settings', 'allow': true, 'context': document}], runTests);

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

remove settings permission.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/220f343d80c2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/220f343d80c2