Closed Bug 970263 Opened 6 years ago Closed 5 years ago

B2G NFC: Enable NFC when running NFC marionette tests

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

RESOLVED FIXED
1.4 S6 (25apr)
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=8])

Attachments

(1 file, 1 obsolete file)

Right now if the screen is off or locked, NFC daemon will enter lower power mode(Disable discovery).

So when running marionette test for NFC, we should also unlock the lockScreen and keeps screen always on.
Duplicate of this bug: 976478
Assignee: nobody → allstars.chh
Hi Yoshi,

I was debugging this problem today.

A change to the settings value 'nfc.enabled' should be observed by nfc_manager.js near line 144. When doing the test steps by hand, I see the event twice, once during boot, and a second time when I enable NFC in the Settings app. But when I run the test case, I only see this event at the beginning; not during the test itself. Any ideas?
Flags: needinfo?(allstars.chh)
I also know this and is checking this too.

It seems before the marionette starts, some Gaia app (communication) has been killed,
and the system app is also gone, so nfc_manager cannot observe the settings change event from head.js.

One thing I also found that is System app is running on b2g process, so the process shouldn't be killed, however it is gone.
Flags: needinfo?(allstars.chh)
Blocks: b2g-NFC-2.0
Blocks: 986527
No longer blocks: b2g-NFC-2.0
Summary: B2G NFC: Unlock screen when running marionette test → B2G NFC: Enable NFC when running NFC marionette tests
This might be related to bug 777840.
Depends on: 777840
Whiteboard: [p=8]
Target Milestone: --- → 1.4 S6 (25apr)
Attached patch Patch. (obsolete) — Splinter Review
blocking-b2g: --- → backlog
Comment on attachment 8405270 [details] [diff] [review]
Patch.

Review of attachment 8405270 [details] [diff] [review]:
-----------------------------------------------------------------

If we will not use setting in test cases maybe we could remove 
SpecialPowers.pushPermissions(
  [{'type': 'settings', 'allow': true, 'context': document}], runTests);
Attachment #8405270 - Flags: review?(dlee) → review+
Attached patch Patch v2.Splinter Review
remove settings permission.
Attachment #8405270 - Attachment is obsolete: true
Attachment #8406724 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/220f343d80c2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.0
Flags: in-moztrap-
Depends on: 1025298
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.