9828 - [malloc] memory allocation problems - nsRenderingContext

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[chris hofmann]

malloc] memory allocation problems - nsRenderingContext

check bug 8227 for more details on what needs to be done to this code

s:/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp
   Deref-error: "state", line 323
   Deref-error: "state", line 333
   Deref-error: "state", line 335
s:/mozilla/gfx/src/gtk/nsRenderingContextGTK.cpp
   Deref-error: "state", line 228
   Deref-error: "state", line 238
   Deref-error: "state", line 242
   Deref-error: "state", line 246
   Deref-error: "state", line 248
   Deref-error: "state", line 249
s:/mozilla/gfx/src/motif/nsRenderingContextMotif.cpp
   Deref-error: "state", line 304
   Deref-error: "state", line 314
   Deref-error: "state", line 316
   Deref-error: "surface", line 846
   Deref-error: "surface", line 847
   Deref-error: "surface", line 848
   Deref-error: "surface", line 849
   Deref-error: "surface", line 850
   Deref-error: "surface", line 854
   Deref-error: "surface", line 855

Comment 1

[Daniel Roberts]

Sorry I took so long--I just arrived back from a trip to Colorado.  Anyway, I
will deal with the memory allocation problems that are in the Motif port.  I
don't think that should be too hard.  However, the Motif GFX code is
horrendously broken in other ways too at the moment, and that is why I've been
working with the Xlib GFX code in combination with the Motif widget code for
now.  But I will correct these memory allocation problems so you can get them
off the radar.

BTW, is there a way one can do a joint assignment of bugs like this where more
than one person may get involved?

Comment 2

[chris hofmann]

you can add additional helpers to the cc list.

Comment 3

[Daniel Roberts]

Fix checked in for the Motif GFX code.

Comment 4

[Daniel Roberts]

Well, now that I've fixed the Motif portion of this bug, I might as well help
out with getting this bug squashed off the radar altogether as well.

Duncan, I am adding you to the CC field, so you can deal with this bug, too; I
am attaching a patch to fix the BeOS side of it for you; I'll let you review my
patch and commit it if you want, since I am not familiar with the BeOS at all.

Pavlov, I am attaching a patch for the GTK+ stuff for you, too.  Again, I'll let
you review it and commit it, since I am not terribly familiar with the internals
of GTK+.

Comment 5

[Daniel Roberts]

Attachment: Duncan, this one's for you.

Comment 6

[Daniel Roberts]

Attachment: Pavlov, this one's for you.

Comment 7

[Daniel Roberts]

Making this bug dependent on the 8227 META bug for tracking.

Comment 8

[Stuart Parmenter]

checked in fix for gtk

Comment 9

[leger]

If this is checked in, can you mark Resolved/Fixed.

Comment 10

[duncan]

Sorry for the delay, the fix is in.