Closed Bug 98292 Opened 23 years ago Closed 23 years ago

Implement image.x and image.y

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: jst, Assigned: jst)

References

Details

(Whiteboard: PDT+, [FIXED ON TRUNK])

Attachments

(2 files)

Proposed fix (plus removing unused pre-imglib2 code).
14.66 KB, patch
Details | Diff | Splinter Review
Same as above but diff -w
9.49 KB, patch
jst
: review+
blizzard
: superreview+
Details | Diff | Splinter Review
4.x supports image.x and image.y, we should implement those in mozilla too for backwards compatibility. Implementing these properties is a matter of mapping them to .offsetXXX, so the implementation should be trivial. This issue was raised in bugscape bug 6113.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
Whiteboard: [HAVE FIX]
Fix looks good, including the changes to remove dead code. r=jrgm, if I may :-] Thanks for doing this. Considering how trivial this change is while giving the benefit of backward compatibility, it would be good to get this on the 0.9.4 branch, or on the post-0.9.4 branch.
Comment on attachment 48244 [details] [diff] [review] Same as above but diff -w sr=blizzard
Attachment #48244 - Flags: superreview+
Fix checked in on the trunk. Pulling back to 0.9.4 to get this on the branch.
Keywords: 4xp, nsbranch
Whiteboard: [HAVE FIX] → [FIXED ON TRUNK]
Target Milestone: mozilla0.9.5 → mozilla0.9.4
Attachment #48244 - Flags: review+
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Nice, might even save us from some WRMBs. nsbranch+
Keywords: nsbranch → nsbranch+
Please check inot the branch today by 3 pm.
Whiteboard: [FIXED ON TRUNK] → PDT+, [FIXED ON TRUNK]
Er, given that it is 4:20pm, what does 'today by 3pm' mean? (At any rate, just to confirm, this does indeed work on the trunk.)
Well, not being able to predict the future, I wasn't able to get this in by 3pm :-) But it's checked in on the branch now.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
another example of PDT under stress... ;-) that should have been 3am to make the next daily build... thanks Johnny
Testcase to verify: <HTML> <HEAD><TITLE></TITLE></HEAD> <BODY> <img src="something.jpg" height="200" width="200"></img> <form name="workform"> <input type="button" value="show me image.x & image.y" onclick="alert('image.x=' + document.images[0].x + ' & image.y=' + document.images[0].y);"> </form> </BODY> </HTML> verified on 2001-10-04-05-0.9.4. need to verify on trunk.
Keywords: vtrunk
Depends on: 587021
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: