Implement image.x and image.y

RESOLVED FIXED in mozilla0.9.5

Status

()

P2
normal
RESOLVED FIXED
17 years ago
8 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Trunk
mozilla0.9.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: PDT+, [FIXED ON TRUNK])

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
4.x supports image.x and image.y, we should implement those in mozilla too for
backwards compatibility. Implementing these properties is a matter of mapping
them to .offsetXXX, so the implementation should be trivial. This issue was
raised in bugscape bug 6113.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 1

17 years ago
Created attachment 48243 [details] [diff] [review]
Proposed fix (plus removing unused pre-imglib2 code).
(Assignee)

Comment 2

17 years ago
Created attachment 48244 [details] [diff] [review]
Same as above but diff -w
(Assignee)

Updated

17 years ago
Whiteboard: [HAVE FIX]

Comment 3

17 years ago
Fix looks good, including the changes to remove dead code. r=jrgm, if I may :-]
Thanks for doing this. Considering how trivial this change is while giving the
benefit of backward compatibility, it would be good to get this on the 0.9.4
branch, or on the post-0.9.4 branch.
Comment on attachment 48244 [details] [diff] [review]
Same as above but diff -w

sr=blizzard
Attachment #48244 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
Fix checked in on the trunk. Pulling back to 0.9.4 to get this on the branch.
Keywords: 4xp, nsbranch
Whiteboard: [HAVE FIX] → [FIXED ON TRUNK]
Target Milestone: mozilla0.9.5 → mozilla0.9.4
(Assignee)

Updated

17 years ago
Attachment #48244 - Flags: review+
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Nice, might even save us from some WRMBs. nsbranch+
Keywords: nsbranch → nsbranch+

Comment 7

17 years ago
Please check inot the branch today by 3 pm.
Whiteboard: [FIXED ON TRUNK] → PDT+, [FIXED ON TRUNK]

Comment 8

17 years ago
Er, given that it is 4:20pm, what does 'today by 3pm' mean?

(At any rate, just to confirm, this does indeed work on the trunk.)

(Assignee)

Comment 9

17 years ago
Well, not being able to predict the future, I wasn't able to get this in by 3pm
:-) But it's checked in on the branch now.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 10

17 years ago
another example of PDT under stress... ;-)
that should have been 3am to make the next daily build...

thanks Johnny

Comment 11

17 years ago
Testcase to verify:

<HTML>
<HEAD><TITLE></TITLE></HEAD>
<BODY>
<img src="something.jpg" height="200" width="200"></img>
<form name="workform">
<input type="button" value="show me image.x & image.y" onclick="alert('image.x=' 
+ document.images[0].x + '  &  image.y=' + document.images[0].y);">
</form>
</BODY>
</HTML>

verified on 2001-10-04-05-0.9.4. need to verify on trunk.
Keywords: vtrunk
Depends on: 587021
You need to log in before you can comment on or make changes to this bug.