Closed
Bug 587021
Opened 14 years ago
Closed 14 years ago
drop HTMLImageElement.x/.y
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
WONTFIX
mozilla7
People
(Reporter: annevk, Assigned: Ms2ger)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
3.38 KB,
patch
|
sicking
:
review+
jst
:
superreview+
benjamin
:
approval2.0-
|
Details | Diff | Splinter Review |
Internet Explorer does not implement these and it would be nice to get rid of them everywhere I think.
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 1•14 years ago
|
||
Unsurprisingly, we don't appear to have tests for this.
Attachment #466006 -
Flags: review?(jonas)
Comment on attachment 466006 [details] [diff] [review] Patch v1 We might actually want to keep binary compatibility here, unfortunately. So simply prefix the attributes in the idl with [noscript] and add a comment stating that these are DEPRECATED. Then keep implementations, but make them simply return NS_ERROR_NOT_IMPLEMENTED or some such. I know this interface isn't marked FROZEN, and that FROZEN doesn't even mean very much any more, but I strongly suspect there are addons that use this interface. r=me with that changed.
Attachment #466006 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 466006 [details] [diff] [review] Patch v1 We already broke them in bug 582303, so I don't see how preserving binary compat here would be useful.
Attachment #466006 -
Flags: superreview?(jst)
Ok, let's stick with this patch then.
|
||
Updated•14 years ago
|
Attachment #466006 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #466006 -
Flags: approval2.0?
|
||
Comment 5•14 years ago
|
||
Comment on attachment 466006 [details] [diff] [review] Patch v1 This is pure risk now, please wait until after branching.
Attachment #466006 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•14 years ago
|
Whiteboard: [needs landing] → [needs landing][not-ready-for-cedar]
|
|
Assignee | |
Updated•14 years ago
|
No longer depends on: post2.0
Whiteboard: [needs landing][not-ready-for-cedar] → [need gk2.2 ship]
Version: unspecified → Trunk
|
||
Updated•14 years ago
|
Whiteboard: [need gk2.2 ship] → [need gk2.2 ship][not-ready-for-cedar]
|
|
||
Comment 6•14 years ago
|
||
This doesn't apply cleanly any more.
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f13a2020b5b9
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Whiteboard: [need gk2.2 ship][not-ready-for-cedar]
Target Milestone: --- → mozilla7
|
||
Updated•13 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
|
||
Comment 8•13 years ago
|
||
Clean-up visible in the content/html/content/src/nsHTMLImageElement.cpp dom/interfaces/html/nsIDOMHTMLImageElement.idl files.
Status: RESOLVED → VERIFIED
|
|
||
Comment 9•13 years ago
|
||
This caused bug 731832.
|
|
Assignee | |
Comment 10•13 years ago
|
||
Backed out: https://hg.mozilla.org/mozilla-central/rev/75c7378c87b6
Resolution: FIXED → WONTFIX
|
||
Comment 11•10 years ago
|
||
Was it intended to WONTFIX on backout? Seems pretty unusual to me ;)
Flags: needinfo?(Ms2ger)
You need to log in
before you can comment on or make changes to this bug.
Description
•