Closed Bug 587021 Opened 10 years ago Closed 9 years ago

drop HTMLImageElement.x/.y

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

VERIFIED WONTFIX
mozilla7

People

(Reporter: annevk, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Internet Explorer does not implement these and it would be nice to get rid of them everywhere I think.
Assignee: nobody → Ms2ger
Blocks: 98292
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Patch v1Splinter Review
Unsurprisingly, we don't appear to have tests for this.
Attachment #466006 - Flags: review?(jonas)
Comment on attachment 466006 [details] [diff] [review]
Patch v1

We might actually want to keep binary compatibility here, unfortunately.

So simply prefix the attributes in the idl with [noscript] and add a comment stating that these are DEPRECATED. Then keep implementations, but make them simply return NS_ERROR_NOT_IMPLEMENTED or some such.

I know this interface isn't marked FROZEN, and that FROZEN doesn't even mean very much any more, but I strongly suspect there are addons that use this interface.

r=me with that changed.
Attachment #466006 - Flags: review?(jonas) → review+
Comment on attachment 466006 [details] [diff] [review]
Patch v1

We already broke them in bug 582303, so I don't see how preserving binary compat here would be useful.
Attachment #466006 - Flags: superreview?(jst)
Ok, let's stick with this patch then.
Attachment #466006 - Flags: superreview?(jst) → superreview+
Attachment #466006 - Flags: approval2.0?
Comment on attachment 466006 [details] [diff] [review]
Patch v1

This is pure risk now, please wait until after branching.
Attachment #466006 - Flags: approval2.0? → approval2.0-
Whiteboard: [needs landing]
Status: NEW → ASSIGNED
Depends on: post2.0
Whiteboard: [needs landing] → [needs landing][not-ready-for-cedar]
No longer depends on: post2.0
Whiteboard: [needs landing][not-ready-for-cedar] → [need gk2.2 ship]
Version: unspecified → Trunk
Whiteboard: [need gk2.2 ship] → [need gk2.2 ship][not-ready-for-cedar]
This doesn't apply cleanly any more.
Blocks: 660439
http://hg.mozilla.org/mozilla-central/rev/f13a2020b5b9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Whiteboard: [need gk2.2 ship][not-ready-for-cedar]
Target Milestone: --- → mozilla7
Clean-up visible in the 
content/html/content/src/nsHTMLImageElement.cpp
dom/interfaces/html/nsIDOMHTMLImageElement.idl
files.
Status: RESOLVED → VERIFIED
Depends on: 731832
This caused bug 731832.
Backed out: https://hg.mozilla.org/mozilla-central/rev/75c7378c87b6
Resolution: FIXED → WONTFIX
Was it intended to WONTFIX on backout? Seems pretty unusual to me ;)
Flags: needinfo?(Ms2ger)
Yes.
Flags: needinfo?(Ms2ger)
You need to log in before you can comment on or make changes to this bug.