983023 - AudioNodeExternalInputStream (MediaElementAudioSourceNode/MediaStreamAudioSourceNode) inserts zero samples into the stream

Status: RESOLVED WORKSFORME

(Core :: Web Audio, defect, P1)

Description

[Karl Tomlinson (:karlt)]

Attachment: add assertion when inserting zero samples

This seems to happen because there is not enough resampled data when the input stream can have varying numbers of samples in each block.

The attachment adds an assertion to detect this as well as removing speex_resampler_skip_zeros, so that the resampler produces output immediately instead of blocking for a period, which might have triggered the assertion even when failures were harmless.

Perhaps bug 818822 might make the resampling here unnecessary.

Comment 1

[Karl Tomlinson (:karlt)]

This assertion, "Should be first", is still failing even though no resampling is happening here now.

At 44100 Hz, the graph time delta for each block oscillates between 3043 and 3044.
The absolute graph time values are chosen so that rounding up to ticks will produce an interval of 128 ticks.

However, the start tick and number of ticks collected for the input(s) is
determined from rounding stream times.  Rounding stream times up to ticks can
mean that input block sizes fluctuate between 127, 128, and 129 ticks.

Comment 2

[Maire Reavy [:mreavy]]

Karl - is this still relevant?  Should we keep this a p1, or drop it to p2 or p3?  (I set the rank to 15 based on the current P1, but I suspect it's either P2 or P3).  Thanks

Comment 3

[Karl Tomlinson (:karlt)]

I suspect this was fixed in bug 1023697.