98307 - QuickSearch does not comply with W3C DOM spec

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P1)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

This *could* be evangelism but I'll file it under Bugzilla ;-)

Currently the JS above will not work for DOM enabled browsers.  I will attach a
patch to fix that.

CCing default Tech Evangelism/US English owners for QA.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch for DOM-alizing the quicksearch

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: There were some unwanted tabs in last patch. This removes them.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

I've done a search thru more files and found some others that exhibit bad DOM

In customised version of Bugzilla, this can cause certain javascripts to fail to
work at all with Mozilla.  (which is how I noticed this).  Here is a list of
files that I've found to contain proprietary DOM include:

bug_form.pl
buglist.cgi
index.html
query.cgi
queryhelp.cgi
quicksearch.html
quicksearchhack.html

Note: since we aim for browser backward compatibility in Bugzilla, I included a
check for if the browser is DOM capable, we use DOM and if not, use the old
proprietary behaviour.

My JS Console will be much happier once this is finally fixed :)

More patches to come!

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

the *.atml files for the attachment templates also suffer from bad DOM.

Comment 5

[Andreas Franke (gone)]

I agree that the code is bad (document.f.id.value, in several places). However,
before fixing it the way you suggest it, I'd very much like to see the fix to
bug 76484 (alias attachment 40917 [details] [diff] [review] in bug 37339) checked in, because it
eliminates the bad code from quicksearch.js altogether. (Ok, it just moves the
problem to different places, but I think it's worth the wait.)

Comment 6

[Gervase Markham [:gerv]]

caillon: feel like splashing this patch's face with water and waking it up?

Gerv

Comment 7

[Dave Miller [:justdave]]

ping caillon...

Comment 8

[Dave Miller [:justdave]]

Per caillon in IRC, this is actually a Mozilla problem, but we should still fix
this to work around it.  I'll let him do the explaining if anyone has any
complaints...

Comment 9

[Jacob Steenhagen]

Bug 70907 is also targeted for 2.18 which would eliminate the QuickSearch 
JavaScript and make it server side perl (giving it a larger usable audience 
and reducing page load time).

Comment 10

[Bradley Baetz (:bbaetz)]

Comment on attachment 48256 [details] [diff] [review]
There were some unwanted tabs in last patch. This removes them.

This code isn't there anymore.

Is there still work to be done, or should this bug be closed?

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Sigh.  No time to work on this anymore...  ->Default owner.

Comment 12

[Dave Miller [:justdave]]

enhancements without current patches are being pushed to 2.20

Comment 13

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.