983070 - [Message][UI Test] The received message should not causes message thread to open in the thread list view.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Askeing Yen[:askeing][:fyen]]

The received message do not causes message thread to open.
Found by gaiatest test_sms_to_dialer.py


Buri
Gaia      e61dc0019d9d6135d88ba15153c37f73a952567e
Gecko     https://hg.mozilla.org/mozilla-central/rev/a10d0ba50f64
BuildID   20140312160210
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

### STR
1. launch message app
2. send the message to target phone from another
3. wait for the message

### Except
1. the received message do not causes message thread to open.

### Actual
1. the received message is displayed on message list, but do not causes message thread to open.

Comment 1

[Julien Wajsberg [:julienw]]

Sorry, I don't understand the difference between Except and Actual?

A receiving message do never cause the message thread to open, we need to click the notification for this. Are you doing this?

Comment 2

[Jason Smith [:jsmith]]

Test case in question here:

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_to_dialer.py

Comment 3

[Askeing Yen[:askeing][:fyen]]

Attachment: VID_0007.3gp

We found 20140311040203 build will open message thread.
Not sure is it the expect result.

Gaia      a351fe62c11737c722ad33aaff438f6ccd00bd4a
Gecko     https://hg.mozilla.org/mozilla-central/rev/41d962d23e81
BuildID   20140311040203
Version   30.0a1


Ref:
Bug 968150
https://github.com/mozilla-b2g/gaia/commit/c82d132233ecf548f0968b2a730f181006ceca71

Comment 4

[Askeing Yen[:askeing][:fyen]]

> ### STR
> 1. launch message app
> 2. send the message to target phone from another
> 3. wait for the message
> 
> ### Except
> 1. the received message do not causes message thread to open.
Julien,

"the received message causes message thread to open."
Sorry for the inconvenience! :(

> ### Actual
> 1. the received message is displayed on message list, but do not causes
> message thread to open.

If the expect result is "DO NOT" automatically open the message thread, that's okay for us to modify the gaiatest test cases :)

Comment 5

[Jason Smith [:jsmith]]

So if I understand this correctly:

Before this test starting failing, we operated under the assumption that when a message was received with the messages app open, but not on the applicable thread, we would jump to the applicable thread without user control. Now, we just get a message, but don't jump to applicable thread, which requires the user to go directly to the thread in question. We're arguing the new behavior is actually the right behavior, which means that the test should be updated & no fix is required in the SMS app.

UX - Does the new behavior align with your expectations of what should happen here?

Comment 6

[Zac C (:zac)]

Just looking at this and there seems to be another (possibly related) issue with threading the two messages together when the sender and receiver is the same phone number. Previously it would merge them into one thread.

Comment 7

[Stephany Wilkes]

Flagging Carrie on message behavior.

Comment 8

[Carrie Wang [New account: [e-mail]]]

redirect to Message owner Omega

Comment 9

[Omega Feng [:Omega] [:馮於懋]]

We should let user decide whether he wants to open a message thread or not. So, in Message List of Messages app, don't open the Message Thread automatically when receiving a message.

Comment 10

[Steve Chung [:steveck]]

Since UX confrimed that we should not switch to thread directly from list view, that means the test case should be changed to match correct behavior. Change the component to UI test.

Comment 11

[Zac C (:zac)]

P1 to unxfail this test.

Comment 12

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 17313

Comment 13

[Florin Strugariu [:Bebe]]

Comment on attachment 8393355 [details] [review]
PR 17313

There are some strange commits in there.

Can we rebase or at least remove the "Merge remote-tracking branch 'mozilla/master' into 983070"

Comment 14

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8393355 [details] [review]
PR 17313

Updated :)

Comment 15

[Zac C (:zac)]

Comment on attachment 8393355 [details] [review]
PR 17313

r+ thanks Askeing!
Apologies for taking a long time to review this!

Comment 16

[Julien Wajsberg [:julienw]]

(In reply to Jason Smith [:jsmith] from comment #5)
> So if I understand this correctly:
> 
> Before this test starting failing, we operated under the assumption that
> when a message was received with the messages app open, but not on the
> applicable thread, we would jump to the applicable thread without user
> control. Now, we just get a message, but don't jump to applicable thread,
> which requires the user to go directly to the thread in question. We're
> arguing the new behavior is actually the right behavior, which means that
> the test should be updated & no fix is required in the SMS app.

What I don't get is that we never behaved like the test expected. So I don't get how it could ever work.

Comment 17

[Julien Wajsberg [:julienw]]

(In reply to Askeing Yen[:askeing] from comment #3)
> Created attachment 8390987 [details]
> VID_0007.3gp
> 
> We found 20140311040203 build will open message thread.
> Not sure is it the expect result.

yeah, this was really a bug. I'm glad it's fixed now!

Comment 18

[Zac C (:zac)]

Resolved
https://github.com/mozilla-b2g/gaia/commit/fe54d0fbb985aee82df52ff7e47b173d17116cf2

Comment 19

[Ryan VanderMeulen [:RyanVM]]

This was uplifted to v1.4 as well.

v1.4: https://github.com/mozilla-b2g/gaia/commit/80fed35f1151507bf5386aa67e4e3471f66bc91d