Closed
Bug 983346
Opened 11 years ago
Closed 11 years ago
Screenshots are getting loaded when viewing mobile compact search view
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-03-18
People
(Reporter: cvan, Assigned: cvan)
References
()
Details
(Keywords: perf, Whiteboard: [qa+])
This bug is two fold:
Desktop:
1. On desktop load https://marketplace.firefox.com/search?q=youtube at full width
2. Notice 6,386.22 KB (6.24 MB!!!!) gets loaded (126 requests, 6.39s): http://cl.ly/image/3P0L3b2M3O1X
3. Click the condensed view toggle: http://cl.ly/image/2O1Y1W303B1Y
4. Notice it doesn't persist when you refresh (bug!): http://cl.ly/image/2z2U062F3L12
Mobile:
1. Fake your User-Agent as Firefox OS ("Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0"). Proof: http://cl.ly/image/1F242i0y3h3S
2. On desktop with responsive mode for 320x480 load https://marketplace.firefox.com/search?q=youtube
3. Make sure the condensed view is toggle.
4. Notice 6,056.66 KB (5.91 MB!!!!) gets loaded (118 requests, 4.40s): http://cl.ly/image/2K2L1k1u3p0Q
5. Gasp in awe that the screenshots are still getting loaded on mobile as Firefox OS, even though they're not visible on screen (bug!).
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → cvan
Target Milestone: --- → 2014-03-18
Assignee | ||
Comment 1•11 years ago
|
||
Well, ladies and gentlemen, hidden `<img>`s get loaded in every browser:
http://jsbin.com/valevose/1/
I have a workaround coming. But, omg. I seem to recall running into this issue a few years ago.
Assignee | ||
Comment 2•11 years ago
|
||
And for the skeptics out there, same thing if you `display:none` the parent element:
http://jsbin.com/yozogeme/1/
Assignee | ||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•11 years ago
|
||
This would be nice to get cherrypicked for Tuesday's tag. If people could kindly test this based on my STR in comment 0, that would be fantastic.
Whiteboard: [qa+]
Comment 5•11 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/search?q=youtube on FF30 (Win 7)
In the console it shows that images are not loaded when in compact view.
Postfix screencast:
Desktop http://screencast.com/t/CaxBVSz1UKm
Mobile http://screencast.com/t/AcaVlig9Pw
Closing bug.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 6•11 years ago
|
||
This was not working on the detail page <https://marketplace-dev.allizom.org/app/youtube-1?src=search>:
https://github.com/mozilla/fireplace/commit/e102e2a
Comment 7•11 years ago
|
||
Could you please add STR on how can I verify the scenario from comment 6? Thank you
Flags: needinfo?(cvan)
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Iulian Timis from comment #7)
> Could you please add STR on how can I verify the scenario from comment 6?
> Thank you
It's working now. No worries.
Flags: needinfo?(cvan)
You need to log in
before you can comment on or make changes to this bug.
Description
•