Closed Bug 983411 Opened 7 years ago Closed 3 years ago
[Messages] Don't send a phone
Number with sim Selected Callback in Multi Sim Action Button if none is set .
No description provided.
Hi Julienw, While working on https://bugzilla.mozilla.org/show_bug.cgi?id=935060, i came across this bug (read in comments). https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/views/conversation/js/conversation.js#L2251 thinking to fix this in Bug 935060 instead of going for separate patch for this bug. What you say? Thanks
hey Julienw, I am fixing this in Bug 935060. Hope this is okay for you. Thanks
Summary: Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set. → [Messages] Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set.
I think you need changes in shared/js/multi_sim_action_button.js (along with unit tests) so it's likely better to do it in a separate patch IMO... And it's not linked at all to bug 935060. So I'd prefer to keep separate patches for this. Sorry again for the delay in my answer :(
Btw, this is the line number: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/views/conversation/js/conversation.js#L2263 Will look into it
Assignee: rishav006 → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.