Closed Bug 983411 Opened 7 years ago Closed 3 years ago

[Messages] Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set.

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: drs, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=js])

No description provided.
Depends on: 947140
Blocks: b2g-dsds-1.4
Hi Julienw, 
While working on https://bugzilla.mozilla.org/show_bug.cgi?id=935060, i came across this bug (read in comments).
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/views/conversation/js/conversation.js#L2251

thinking to fix this in Bug 935060 instead of going for separate patch for this bug.

What you say? 

Thanks
Flags: needinfo?(felash)
Assignee: nobody → rishav006
hey Julienw,
I am fixing this in Bug 935060. Hope this is okay for you.
Thanks
Mentor: felash
Summary: Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set. → [Messages] Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set.
I think you need changes in shared/js/multi_sim_action_button.js (along with unit tests) so it's likely better to do it in a separate patch IMO... And it's not linked at all to bug 935060. So I'd prefer to keep separate patches for this.

Sorry again for the delay in my answer :(
Flags: needinfo?(felash)
Flags: needinfo?(rishav006)
Assignee: rishav006 → nobody
Flags: needinfo?(rishav006)
Whiteboard: [lang=js]
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.