983411 - [Messages] Don't send a phoneNumber with simSelectedCallback in MultiSimActionButton if none is set.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[kumar rishav (:rishav_)]

Hi Julienw, 
While working on https://bugzilla.mozilla.org/show_bug.cgi?id=935060, i came across this bug (read in comments).
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/views/conversation/js/conversation.js#L2251

thinking to fix this in Bug 935060 instead of going for separate patch for this bug.

What you say? 

Thanks

Comment 2

[kumar rishav (:rishav_)]

hey Julienw,
I am fixing this in Bug 935060. Hope this is okay for you.
Thanks

Comment 3

[Julien Wajsberg [:julienw]]

I think you need changes in shared/js/multi_sim_action_button.js (along with unit tests) so it's likely better to do it in a separate patch IMO... And it's not linked at all to bug 935060. So I'd prefer to keep separate patches for this.

Sorry again for the delay in my answer :(

Comment 4

[kumar rishav (:rishav_)]

Btw, this is the line number: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/views/conversation/js/conversation.js#L2263

Will look into it

Comment 5

[BMO Automation]

Firefox OS is not being worked on