983424 - World cup RSS add-on

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Margaret Leibovic]

For Fx30, we want to make a hub add-on that lets users follow a feed of world cup news.

We should use the user's current country to choose a default feed, but provide some add-ons settings UI to let them switch to a different feed, if there's a different country they prefer.

Ideally this add-on will be localized, at least in the locales where we intend to market this.

We can use mcomella's RSS code as a jumping off point for this:
https://github.com/mcomella/fennec_rss/tree/list_integration

Perhaps we should move some of this RSS parsing code off into a little module that we can import and share between this add-on and the add-on I'm developing for bug 977200.

Comment 1

[:Margaret Leibovic]

FYI, I'm working on this here:
https://github.com/leibovic/world-cup-feed

I still need to implement actually being smart about which feed we choose based on country/locale, and possibly add add-on settings to let the user change this, but this seems to be working well otherwise (currently hard-coded to use US feed).

Comment 2

[:Margaret Leibovic]

Status update: I think this is just about done! The only remaining bit is to make the last-resort fallback country a bit smarter.

I have the settings options working, which allows you to switch to feeds from different countries (however, you need a build with the patch from bug 985875 for this to work). There's also a bit of flashing jankiness in the add-on manager when you use this menulist, so I think I'll recruit wesj to help look into that bug.

I was able to use regionNames.properties to get strings for the countries (sweet), so this add-on only has 2 strings total that would need localization. I also filed bug 988582 about getting this localized for real.

Latest code and XPI here:
https://github.com/leibovic/world-cup-feed
http://people.mozilla.org/~mleibovic/worldcupfeed.xpi

wesj, maybe you want to take a look at the code to see if it's reasonable?

Comment 3

[:Margaret Leibovic]

Also needinfo to ibarlow for an add-on title/description/icon for me to put this up on AMO for wider testing.

Comment 4

[Aaron Train [:aaronmt]]

Drive by early testing because why not, couple questions for either Margaret or Ian

* Can we treat each feed item like a link? I wanted to open a couple of the stories in background tabs, I long-tapped on each and got no context menu

* How is RSS refresh and RSS earlier feed fetch handled (e.g, pull to refresh at top and pull to fetch at bottom?)

Comment 5

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #4)
> Drive by early testing because why not, couple questions for either Margaret
> or Ian

Wonderful! Thank you for testing :)

> * Can we treat each feed item like a link? I wanted to open a couple of the
> stories in background tabs, I long-tapped on each and got no context menu

Right now we haven't planned context menu support into dynamic panels, but that would be a good feature request. For a first iteration, we might be able to show a set of basic context menu items for views that use the default BROWSER item handler (currently we support either opening the items directly in the browser, or launching an intent with them). I don't know that this is something that is important enough for Fx30, but definitely worth addressing. I'll file a bug!

> * How is RSS refresh and RSS earlier feed fetch handled (e.g, pull to
> refresh at top and pull to fetch at bottom?)

Bug 970707 is filed about pull-to-refresh. Currently hub lists don't support loading more items (or any sort of batching). They just load all the items that are currently in that dataset.

Comment 6

[:Margaret Leibovic]

I'm resolving this bug, since I made the add-on. We can continue to develop it on github, and I'm going to work with product marketing to create the add-on listing on AMO.

Comment 7

[:Margaret Leibovic]

Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).

Filter on epic-hub-bugs.