983603 - Collate some example starcomment.php & submitBuildStar.php POSTs for possible treeherder backward compatibility support

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

As part of discussions around transition plans from TBPL to treeherder, a few things came up that we may wish to do:

1) Get treeherder to emulate the TBPL front-end POSTs made to starcomment.php, so we can continue to populate the OrangeFactor ES DB (and thus continue to use OrangeFactor) until OrangeFactor is rewritten to use the treeherder DB directly.

2) Possibly get treeherder to submit star data to TBPL's submitBuildStar.php, so we can use treeherder as our primary dashboard, but more easily fall back to TBPL in case of issues or for use-cases that treeherder may not fully support in v1 (eg reftest compare or other such tools).

#1 is the most important, and likely also the most viable for treeherder to emulate. #2 will depend on us being able to map treeherders UUIDs to the TBPL job id (which iirc is the buildbot id; and thus treeherder would need to store it anyway for retrigger functionality, and so might not be much more effort after all).

I'll capture a few example TBPL front-end POSTs and dump them in this bug so we can evaluate the difficulty of the above more easily.

Comment 1

[Ed Morley [:emorley]]

Single bug starred:

POST https://tbpl.mozilla.org/php/starcomment.php
# Request Headers:
User-Agent:	Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Referer:	https://tbpl-dev.allizom.org/?tree=Mozilla-Inbound
Pragma:	no-cache
Origin:	https://tbpl-dev.allizom.org
Host:	tbpl.mozilla.org
DNT:	1
Content-Type:	application/x-www-form-urlencoded; charset=UTF-8
Content-Length:	281
Connection:	keep-alive
Cache-Control:	no-cache
Accept-Language:	en-US,en;q=0.5
Accept-Encoding:	gzip, deflate
Accept:	*/*
# Request Body:
buildname=Android+4.0+Panda+mozilla-inbound+opt+test+robocop-3&machinename=panda-0727&os=android-4-0&date=2014-05-09&type=Robocop&buildtype=opt&starttime=1399644565&logfile=39361741&tree=integration%2Fmozilla-inbound&rev=fd2e731b7153&who=pp&comment=Bug+1006242&timestamp=1399647406
# Response Headers:
X-Cache-Info:	not cacheable; request wasn't a GET or HEAD
X-Backend-Server:	generic3.webapp.phx1.mozilla.com
Strict-Transport-Security:	max-age=15768000 ; includeSubDomains
Server:	Apache
Keep-Alive:	timeout=5, max=1000
Expires:	Fri, 09 May 2014 15:11:46 GMT
Date:	Fri, 09 May 2014 14:56:46 GMT
Content-Type:	text/html; charset=UTF-8
Content-Length:	0
Connection:	Keep-Alive
Cache-Control:	max-age=900
# Response Body:
<none>

POST https://tbpl-dev.allizom.org/php/submitBuildStar.php
# Request Headers:
X-Requested-With:	XMLHttpRequest
User-Agent:	Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Referer:	https://tbpl-dev.allizom.org/?tree=Mozilla-Inbound
Pragma:	no-cache
Host:	tbpl-dev.allizom.org
DNT:	1
Content-Type:	application/x-www-form-urlencoded; charset=UTF-8
Content-Length:	79
Connection:	keep-alive
Cache-Control:	no-cache
Accept-Language:	en-US,en;q=0.5
Accept-Encoding:	gzip, deflate
Accept:	*/*
# Request Body:
id=39361741&who=pp&note=Bug+1006242&machinename=panda-0727&starttime=1399644565
# Response Headers:
X-Backend-Server:	generic1.dev.webapp.phx1.mozilla.com
Strict-Transport-Security:	max-age=15768000 ; includeSubDomains
Server:	Apache
Keep-Alive:	timeout=5, max=1000
Expires:	Fri, 09 May 2014 15:11:45 GMT
Date:	Fri, 09 May 2014 14:56:45 GMT
Content-Type:	application/json, charset=utf-8
Content-Length:	0
Connection:	Keep-Alive
Cache-Control:	max-age=900
access-control-allow-origin:	*
# Response Body:
<none>


POST https://tbpl-dev.allizom.org/php/submitBugzillaComment.php
# Request Headers:
X-Requested-With:	XMLHttpRequest
User-Agent:	Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Referer:	https://tbpl-dev.allizom.org/?tree=Mozilla-Inbound
Pragma:	no-cache
Host:	tbpl-dev.allizom.org
DNT:	1
Content-Type:	application/x-www-form-urlencoded; charset=UTF-8
Content-Length:	1447
Connection:	keep-alive
Cache-Control:	no-cache
Accept-Language:	en-US,en;q=0.5
Accept-Encoding:	gzip, deflate
Accept:	*/*
# Request Body:
id=1006242&comment=pp%0Ahttps%3A%2F%2Ftbpl.mozilla.org%2Fphp%2FgetParsedLog.php%3Fid%3D39361741%26tree%3DMozilla-Inbound%0AAndroid+4.0+Panda+mozilla-inbound+opt+test+robocop-3+on+2014-05-09+07%3A09%3A25%0Arevision%3A+fd2e731b7153%0Aslave%3A+panda-0727%0A%0A23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0Ajunit.framework.AssertionFailedError%3A+23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0A24+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Exception+caught+-+junit.framework.AssertionFailedError%3A+23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0A05-09+07%3A25%3A03.585+I%2FRobocop+(+2728)%3A+23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0A05-09+07%3A25%3A13.843+I%2FRobocop+(+2728)%3A+junit.framework.AssertionFailedError%3A+23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0A05-09+07%3A25%3A13.859+I%2FRobocop+(+2728)%3A+24+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Exception+caught+-+junit.framework.AssertionFailedError%3A+23+INFO+TEST-UNEXPECTED-FAIL+%7C+testMasterPassword+%7C+Doorhanger+notification+is+hidden+-+got+true%2C+expected+false%0AReturn+code%3A+1
# Response Headers:
X-Backend-Server:	generic1.dev.webapp.phx1.mozilla.com
Strict-Transport-Security:	max-age=15768000 ; includeSubDomains
Server:	Apache
Keep-Alive:	timeout=5, max=1000
Expires:	Fri, 09 May 2014 15:11:46 GMT
Date:	Fri, 09 May 2014 14:56:46 GMT
Content-Type:	text/plain; charset=UTF-8
Content-Length:	13
Connection:	Keep-Alive
Cache-Control:	max-age=900
access-control-allow-origin:	*
# Response Body:
{"id":210933}

Comment 2

[Ed Morley [:emorley]]

Multiple bugs starred for one job:


POST https://tbpl.mozilla.org/php/starcomment.php

# Request Body:
buildname=b2g_emulator_vm+try+debug+test+mochitest-debug-6&machinename=tst-linux64-spot-305&os=b2g-emu-ics&date=2014-05-09&type=Mochitest&buildtype=debug&starttime=1399632605&logfile=39350856&tree=try&rev=62c7991c3c7a&who=edmorley%23dev&comment=Bug+832768%2C+bug+965677&timestamp=1399647928

# Response Body:
<none>


POST https://tbpl.allizom.org/php/submitBugzillaComment.php

# Request Body:
id=832768&comment=edmorley%23dev%0Ahttps%3A%2F%2Ftbpl.mozilla.org%2Fphp%2FgetParsedLog.php%3Fid%3D39350856%26tree%3DTry%0Ab2g_emulator_vm+try+debug+test+mochitest-debug-6+on+2014-05-09+03%3A50%3A05%0Arevision%3A+62c7991c3c7a%0Aslave%3A+tst-linux64-spot-305%0A%0AB2GRunner+TEST-UNEXPECTED-FAIL+%7C+%2Ftests%2Fcontent%2Fmedia%2Ftest%2Ftest_chaining.html+%7C+application+timed+out+after+450.0+seconds+with+no+output%0APROCESS-CRASH+%7C+%2Ftests%2Fcontent%2Fmedia%2Ftest%2Ftest_chaining.html+%7C+application+crashed+%5B%40+mozilla%3A%3AMediaDecoderStateMachine%3A%3AGetClock()%5D%0AReturn+code%3A+247%0A05-09+11%3A21%3A26.337+++729+++931+F+MOZ_Assert%3A+Assertion+failure%3A+mCurrentFrameTime+%3C%3D+clock_time+%7C%7C+mPlaybackRate+%3C%3D+0+(Clock+should+go+forwards+if+the+playback+rate+is+%3E+0.)%2C+at+..%2F..%2F..%2Fgecko%2Fcontent%2Fmedia%2FMediaDecoderStateMachine.cpp%3A2391

# Response Body:
{"id":210995}


POST https://tbpl.allizom.org/php/submitBugzillaComment.php

# Request Body:
id=965677&comment=edmorley%23dev%0Ahttps%3A%2F%2Ftbpl.mozilla.org%2Fphp%2FgetParsedLog.php%3Fid%3D39350856%26tree%3DTry%0Ab2g_emulator_vm+try+debug+test+mochitest-debug-6+on+2014-05-09+03%3A50%3A05%0Arevision%3A+62c7991c3c7a%0Aslave%3A+tst-linux64-spot-305%0A%0AB2GRunner+TEST-UNEXPECTED-FAIL+%7C+%2Ftests%2Fcontent%2Fmedia%2Ftest%2Ftest_chaining.html+%7C+application+timed+out+after+450.0+seconds+with+no+output%0APROCESS-CRASH+%7C+%2Ftests%2Fcontent%2Fmedia%2Ftest%2Ftest_chaining.html+%7C+application+crashed+%5B%40+mozilla%3A%3AMediaDecoderStateMachine%3A%3AGetClock()%5D%0AReturn+code%3A+247%0A05-09+11%3A21%3A26.337+++729+++931+F+MOZ_Assert%3A+Assertion+failure%3A+mCurrentFrameTime+%3C%3D+clock_time+%7C%7C+mPlaybackRate+%3C%3D+0+(Clock+should+go+forwards+if+the+playback+rate+is+%3E+0.)%2C+at+..%2F..%2F..%2Fgecko%2Fcontent%2Fmedia%2FMediaDecoderStateMachine.cpp%3A2391

# Response Body:
{"id":210994}


POST https://tbpl.mozilla.org/php/submitBuildStar.php

# Request Body:
id=39350856&who=edmorley%23dev&note=Bug+832768%2C+bug+965677&machinename=tst-linux64-spot-305&starttime=1399632605

# Response Body:
<none>

Comment 3

[Ed Morley [:emorley]]

starcomment.php
The request bodies cleaned up a bit...

# starcomment.php (The submission to Elastic Search)
buildname=b2g_emulator_vm+try+debug+test+mochitest-debug-6
&machinename=tst-linux64-spot-305
&os=b2g-emu-ics
&date=2014-05-09
&type=Mochitest
&buildtype=debug
&starttime=1399632605
&logfile=39350856
&tree=try
&rev=62c7991c3c7a
&who=edmorley#dev
&comment=Bug+832768,+bug+965677
&timestamp=1399647928

# submitBugzillaComment.php (The Bug comment)
id=832768
&comment=edmorley#dev
https://tbpl.mozilla.org/php/getParsedLog.php?id=39350856&tree=Try
b2g_emulator_vm+try+debug+test+mochitest-debug-6+on+2014-05-09+03:50:05
revision:+62c7991c3c7a
slave:+tst-linux64-spot-305

B2GRunner+TEST-UNEXPECTED-FAIL+|+/tests/content/media/test/test_chaining.html+|+application+timed+out+after+450.0+seconds+with+no+output
PROCESS-CRASH+|+/tests/content/media/test/test_chaining.html+|+application+crashed+[@+mozilla::MediaDecoderStateMachine::GetClock()]
Return+code:+247
05-09+11:21:26.337+++729+++931+F+MOZ_Assert:+Assertion+failure:+mCurrentFrameTime+<=+clock_time+||+mPlaybackRate+<=+0+(Clock+should+go+forwards+if+the+playback+rate+is+>+0.),+at+../../../gecko/content/media/MediaDecoderStateMachine.cpp:2391

# submitBuildStar.php (The TBPL DB comment that is displayed in the TBPL UI)
id=39350856
&who=edmorley#dev
&note=Bug+832768,+bug+965677
&machinename=tst-linux64-spot-305
&starttime=1399632605

Comment 4

[Ed Morley [:emorley]]

> # starcomment.php (The submission to Elastic Search)
> buildname=b2g_emulator_vm+try+debug+test+mochitest-debug-6

Buildername from builds-4hr

> &machinename=tst-linux64-spot-305

Machine name

> &os=b2g-emu-ics

TBPL's internal name for that platform (yeah helpful I know). We can always just make a best effort here, since it's only really used in filtering on OF iirc.

> &date=2014-05-09
> &type=Mochitest
> &buildtype=debug
> &starttime=1399632605

Self-explanatory :-)

> &logfile=39350856

This is the ID as found in:
https://tbpl.mozilla.org/php/getParsedLog.php?id=39350856&tree=Try

However I think this isn't used for anything in OF any more (the functionality that relied on this broke ages iirc).

> &tree=try
> &rev=62c7991c3c7a

Self-explanatory :-)

> &who=edmorley#dev

The nickname/username of the person, as self-entered in the TBPL UI.

> &comment=Bug+832768,+bug+965677

The content of the comment field, which starts as a comma separated bug list (based on the user pressing the star icons), but can be hand-edited by the user afterwards - and can also contain no bug number at all - though only ones that contain a bug number are processed:
https://hg.mozilla.org/webtools/tbpl/file/4cd82e3fd793/php/starcomment.php#l152

> &timestamp=1399647928

Time of submission of the star comment I think?

> # submitBugzillaComment.php (The Bug comment)
> id=832768

The bug id.

> &comment=edmorley#dev
> https://tbpl.mozilla.org/php/getParsedLog.php?id=39350856&tree=Try
> b2g_emulator_vm+try+debug+test+mochitest-debug-6+on+2014-05-09+03:50:05
> revision:+62c7991c3c7a
> slave:+tst-linux64-spot-305
> 
> B2GRunner+TEST-UNEXPECTED-FAIL+|+/tests/content/media/test/test_chaining.
> html+|+application+timed+out+after+450.0+seconds+with+no+output
> PROCESS-CRASH+|+/tests/content/media/test/test_chaining.
> html+|+application+crashed+[@+mozilla::MediaDecoderStateMachine::GetClock()]
> Return+code:+247
> 05-09+11:21:26.337+++729+++931+F+MOZ_Assert:+Assertion+failure:
> +mCurrentFrameTime+<=+clock_time+||+mPlaybackRate+<=+0+(Clock+should+go+forwa
> rds+if+the+playback+rate+is+>+0.),+at+../../../gecko/content/media/
> MediaDecoderStateMachine.cpp:2391

The bug comment, somewhat arbitrary, and we ideally don't want to be commenting on bugs once we have a more reliable (and featureful) OrangeFactor. Though not sure at this point if we need to continue doing this with treeherder at least for the short term until OF is fixed up.

> # submitBuildStar.php (The TBPL DB comment that is displayed in the TBPL UI)
> id=39350856
> &who=edmorley#dev
> &note=Bug+832768,+bug+965677
> &machinename=tst-linux64-spot-305
> &starttime=1399632605

Not sure if we need to submit the comment to TBPL's DB as well, need to decide whether this will help the transition or not.