983618 - `inprocess-browser-shown` is triggered too early, causing race conditions

Status: RESOLVED WONTFIX

(Core :: IPC, defect)

Description

[Jan Keromnes [:janx]]

Currently, `inprocess-browser-shown` is triggered just before the child framescripts start being loaded:

http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsFrameLoader.cpp#1726-1736

This causes race conditions for in-process apps in bug #983610, because the code it runs upon receiving `inprocess-browser-shown` expects the framescripts to be fully loaded.

Comment 1

[Jan Keromnes [:janx]]

Maybe "inprocess-browser-shown" could be renamed to "inprocess-browser-pending", but I think "inprocess-browser-shown" needs to be triggered only once all framescripts are loaded. Mark, do you agree?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to Jan Keromnes [:janx] from comment #1)
> Maybe "inprocess-browser-shown" could be renamed to
> "inprocess-browser-pending", but I think "inprocess-browser-shown" needs to
> be triggered only once all framescripts are loaded. Mark, do you agree?

That sounds fine to me and would make the "inprocess-browser-*" notifications consistent with the "remote-browser-*" notifications.  FTR, see also bug 952176 - gaia also relies on these notifications, so any rename of the existing notifications may also be necessary there.

Comment 3

[Jan Keromnes [:janx]]

Actually, the framescript loading problem was caused by something else. I don't think this bug is needed anymore.