Closed Bug 983618 Opened 10 years ago Closed 10 years ago

`inprocess-browser-shown` is triggered too early, causing race conditions

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: janx, Unassigned)

References

Details

Currently, `inprocess-browser-shown` is triggered just before the child framescripts start being loaded:

http://dxr.mozilla.org/mozilla-central/source/content/base/src/nsFrameLoader.cpp#1726-1736

This causes race conditions for in-process apps in bug #983610, because the code it runs upon receiving `inprocess-browser-shown` expects the framescripts to be fully loaded.
Maybe "inprocess-browser-shown" could be renamed to "inprocess-browser-pending", but I think "inprocess-browser-shown" needs to be triggered only once all framescripts are loaded. Mark, do you agree?
Flags: needinfo?(mhammond)
(In reply to Jan Keromnes [:janx] from comment #1)
> Maybe "inprocess-browser-shown" could be renamed to
> "inprocess-browser-pending", but I think "inprocess-browser-shown" needs to
> be triggered only once all framescripts are loaded. Mark, do you agree?

That sounds fine to me and would make the "inprocess-browser-*" notifications consistent with the "remote-browser-*" notifications.  FTR, see also bug 952176 - gaia also relies on these notifications, so any rename of the existing notifications may also be necessary there.
Flags: needinfo?(mhammond)
Actually, the framescript loading problem was caused by something else. I don't think this bug is needed anymore.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.