Closed Bug 983697 Opened 6 years ago Closed 6 years ago
Fill loop-client repository with basic server & readme
Need to setup: /Makefile (targets: runserver, test, lint, frontend) /test /static and anything else needed for basic infra.
No description provided.
Pull request attached.
Attachment #8392864 - Flags: review?(standard8)
Attachment #8392864 - Flags: review?(standard8) → review?(dmose)
Comment on attachment 8392864 [details] [review] https://github.com/mozilla/loop-client/pull/1 This seems like the time to set up our code-sharing infrastructure, and I think we want to do some of that in this patch, so r- for now. Thoughts on a possible structure in <https://github.com/mozilla/loop-client/pull/1>.
Attachment #8392864 - Flags: review?(dmose) → review-
Following the discussion in https://github.com/mozilla/loop-client/pull/1, I tried to find a short-term solution by just creating a `shared/` subfolder for now.
Comment on attachment 8393611 [details] [diff] [review] Link to Github pull-request: https://github.com/mozilla/loop-client/pull/1/files We did a f2f code review of this, addressing concerns as we went. r=dmose with the latest changes pushed to the PR.
Attachment #8393611 - Flags: review?(dmose) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I don't think this needs QA before release. Please needinfo me to request specific testing.
You need to log in before you can comment on or make changes to this bug.