Closed
Bug 983697
Opened 12 years ago
Closed 12 years ago
Fill loop-client repository with basic server & readme
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: standard8, Unassigned)
References
Details
User Story
Need to setup: /Makefile (targets: runserver, test, lint, frontend) /test /static and anything else needed for basic infra.
Attachments
(1 file, 1 obsolete file)
|
51 bytes,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•12 years ago
|
User Story: (updated)
|
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → nperriault
|
Assignee | |
Comment 1•12 years ago
|
||
Pull request attached.
Attachment #8392864 -
Flags: review?(standard8)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #8392864 -
Flags: review?(standard8) → review?(dmose)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8392864 [details] [review]
https://github.com/mozilla/loop-client/pull/1
This seems like the time to set up our code-sharing infrastructure, and I think we want to do some of that in this patch, so r- for now. Thoughts on a possible structure in <https://github.com/mozilla/loop-client/pull/1>.
Attachment #8392864 -
Flags: review?(dmose) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Following the discussion in https://github.com/mozilla/loop-client/pull/1, I tried to find a short-term solution by just creating a `shared/` subfolder for now.
|
|
||
Comment 4•12 years ago
|
||
Attachment #8392864 -
Attachment is obsolete: true
Attachment #8393611 -
Flags: review?(dmose)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8393611 [details] [diff] [review]
Link to Github pull-request: https://github.com/mozilla/loop-client/pull/1/files
We did a f2f code review of this, addressing concerns as we went. r=dmose with the latest changes pushed to the PR.
Attachment #8393611 -
Flags: review?(dmose) → review+
|
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•12 years ago
|
||
|
|
Reporter | |
Comment 7•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Target Milestone: --- → mozilla33
I don't think this needs QA before release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•