983903 - [Gtk3] Ctrl+A doesn't work in textarea or input elements

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Cork]

Hitting Ctrl+A to select all the text in input fields or textareas doesn't have any effect.

Comment 1

[Hubert Figuiere [:hub]]

I wonder if that is not the same as bug 982966

Comment 2

[Karl Tomlinson (:karlt)]

Is this a recent regression?

Comment 3

[Cork]

I've just recently been able to get gtk3 to build, so can't say. Source from say last month fail to build for me.

Comment 4

[Hubert Figuiere [:hub]]

(In reply to Karl Tomlinson (:karlt) from comment #2)
> Is this a recent regression?

Didn't happen in Gtk2. This happens in the Gtk3 build - not sure how it worked before. I also just recently switched to building Gtk3 for testing.

Comment 5

[Cork]

(In reply to Hubert Figuiere [:hub] from comment #4)
> (In reply to Karl Tomlinson (:karlt) from comment #2)
> > Is this a recent regression?
> 
> Didn't happen in Gtk2. This happens in the Gtk3 build - not sure how it
> worked before. I also just recently switched to building Gtk3 for testing.

Ya, this is gtk3 only, gtk2 still works just fine for me (same commit)

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

It's because the key theme is bundled for gtk2 only now.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8400040 [details] [diff] [review]
patch

Neil, I see you reviewed this part already, can you check this one please? Thanks.

Comment 8

[Hubert Figuiere [:hub]]

Seems to work much better with this patch. Thanks !

Comment 9

[[e-mail]]

Comment on attachment 8400040 [details] [diff] [review]
patch

Ah yes, for textfields the XBL handlers get to execute before the native handlers, so you're seeing the emacs handlers in this case. (Note that ehsan recently changed the order for contenteditable regions and design mode documents so that you'll find that Ctrl+A follows the GTK preferences in that case.)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6baf0853ab

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a6baf0853ab

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi Cork, would you mind verifying that this is fixed? Thanks!

Mihaela, is this something already in automated tests?

Comment 13

[Cork]

Verified fixed in https://hg.mozilla.org/mozilla-central/rev/5fa70bd90a8b

Comment 15

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Liz Henry :lizzard from comment #12)
> Mihaela, is this something already in automated tests?

Not as far as I am aware of.