Closed
Bug 984078
Opened 10 years ago
Closed 10 years ago
[Gtk3] Menu entries doesn't align in Web Developer sub menu
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
VERIFIED
FIXED
mozilla31
People
(Reporter: cork, Assigned: stransky)
References
Details
Attachments
(2 files, 1 obsolete file)
110.42 KB,
image/png
|
Details | |
1.93 KB,
patch
|
Details | Diff | Splinter Review |
The menu entries in the Web Developer submenu doesn't align on the left side.
Assignee | ||
Comment 2•10 years ago
|
||
That's more general problem. Some menu entries (like complete View->Character encoding) ignores minimal menu item size and seems to missing border/padding too. No idea why most of them are rendered correctly and some ones not...
Assignee | ||
Comment 3•10 years ago
|
||
It's because we use different borders for check/radio menu items. This patch sync border types for all menu items.
Attachment #8408979 -
Flags: review?(karlt)
Comment 4•10 years ago
|
||
Comment on attachment 8408979 [details] [diff] [review] patch > return MOZ_GTK_SUCCESS; > } >- case MOZ_GTK_CHECKMENUITEM: >- case MOZ_GTK_RADIOMENUITEM: >- ensure_check_menu_item_widget(); >- w = gCheckMenuItemWidget; > break; Please remove this "break" line, which is now unreachable.
Attachment #8408979 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #8408979 -
Attachment is obsolete: true
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1aafbda8e4
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e1aafbda8e4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Verified with http://hg.mozilla.org/mozilla-central/rev/b79c2995d25e
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•