984078 - [Gtk3] Menu entries doesn't align in Web Developer sub menu

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Cork]

Attachment: web-developer.png

The menu entries in the Web Developer submenu doesn't align on the left side.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Yeah, I can see it too.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

That's more general problem. Some menu entries (like complete View->Character encoding) ignores minimal menu item size and seems to missing border/padding too. No idea why most of them are rendered correctly and some ones not...

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Attachment: patch

It's because we use different borders for check/radio menu items. This patch sync border types for all menu items.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8408979 [details] [diff] [review]
patch

>             return MOZ_GTK_SUCCESS;
>         }
>-    case MOZ_GTK_CHECKMENUITEM:
>-    case MOZ_GTK_RADIOMENUITEM:
>-        ensure_check_menu_item_widget();
>-        w = gCheckMenuItemWidget;
>         break;

Please remove this "break" line, which is now unreachable.

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Attachment: patch for check-in

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1aafbda8e4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4e1aafbda8e4

Comment 8

[Cork]

Verified with http://hg.mozilla.org/mozilla-central/rev/b79c2995d25e