Closed Bug 984118 Opened 7 years ago Closed 7 years ago

[Calendar] JSHint fixes for test/unit

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: kgrandon, Assigned: evanxd)

References

Details

(Whiteboard: [p=5])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
We would like to have these files passing JSHint.
Assignee: nobody → evanxd
Target Milestone: --- → 1.4 S4 (28mar)
Attached file Pull request
Status: NEW → ASSIGNED
Whiteboard: [priority][p=5]
Whiteboard: [priority][p=5] → [p=5]
Comment on attachment 8399067 [details] [review]
Pull request

Hi Kevin,

Please help me to review the patch.
Thanks.
Attachment #8399067 - Flags: review?(kgrandon)
Flags: needinfo?(kgrandon)
Target Milestone: 1.4 S4 (28mar) → 1.4 S5 (11apr)
Comment on attachment 8399067 [details] [review]
Pull request

I don't really like the large swaths of comments due to early returns. Could we instead add a /* jshint -W027 */ inside of each scope where we early return?
Attachment #8399067 - Flags: review?(kgrandon)
Flags: needinfo?(kgrandon) → needinfo?(evanxd)
Hi Kevin,
Sure.
Learned, thanks.
Flags: needinfo?(evanxd)
Comment on attachment 8399067 [details] [review]
Pull request

Hi Kevin,

Already updated for your comments, and the Travis light is green.
Please help me to review the patch.

Thanks.
Attachment #8399067 - Flags: review?(kgrandon)
Comment on attachment 8399067 [details] [review]
Pull request

This is awesome! Thank you so much for doing this.
Attachment #8399067 - Flags: review?(kgrandon) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/69dd89cf38cf04acc0f0c6ddacb8e3d0d47a4360
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.