984251 - ./bin/gaia-test and Travis-CI unit tests should be working with test_apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #977449 +++

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks we need to patch test-agent, WIPs are coming.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: gaia.patch

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: test-agent.patch

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

root cause is we only can pass one |path| argument to test-agent by a config file, so WIPs are used to modify |path| to |paths| for our purpose.

WIPs are only for concept so it doesn't work for now.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Attachment: Js-test-agent PR

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia-node-modules PR

Comment 8

[Ricky Chien [:rickychien] (inactive)]

The cause has been found due to test-agent only search files in gaia/apps/.
So we can solve this by supporting multiple path search which including gaia/test_apps/.

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8393966 [details] [review]
Js-test-agent PR

Cool! please fix the nits before landed!

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Merged.

gaia: https://github.com/mozilla-b2g/gaia/commit/a24fbea617fc9458ec41807fc50b9fba9d809ad4
js-test-agnet: https://github.com/mozilla-b2g/js-test-agent/commit/0b6712fb606df1decb1b278332595e0b5e2b54b8
gaia-node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/848a4eacbd0f22e940856e87e435fc550c6b80a4