984289 - [B2G] [RIL] add marionette-webapi tests for conference error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

To complete the test case coverage :)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: v1

support "removeError" and "addError"

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: v1

support "addError" and "removeError"

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8392142 [details] [diff] [review]
v1

Review of attachment 8392142 [details] [diff] [review]:
-----------------------------------------------------------------

I had concern about the execution time of this script.  It already takes 20+ seconds on try server now [1] and we still want to add more.  It seems fine because we have MARIONETTE_TIMEOUT set to 60 seconds, but I have seen some test cases take 2 or 3 times more than ordinary on try server.  Please consider dividing this long script into smaller parts next time.

[1]: https://tbpl.mozilla.org/php/getParsedLog.php?id=36299120&tree=B2g-Inbound&full=1

::: dom/telephony/test/marionette/test_conference.js
@@ +680,5 @@
> +  let outInfo = OutCallStrPool(outNumber);
> +  let inInfo = InCallStrPool(inNumber);
> +  let inInfo2 = InCallStrPool(inNumber2);
> +  let inInfo3 = InCallStrPool(inNumber3);
> +  let inInfo4 = InCallStrPool(inNumber4);

nit: these functions shouldn't have their first letters capital.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://tbpl.mozilla.org/?tree=Try&rev=8c34082c14d4 try green.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment 3 addressed: https://hg.mozilla.org/integration/b2g-inbound/rev/b681e753a9a2

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b681e753a9a2