Closed
Bug 984289
Opened 11 years ago
Closed 11 years ago
[B2G] [RIL] add marionette-webapi tests for conference error
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S4 (28mar)
People
(Reporter: hsinyi, Assigned: hsinyi)
References
Details
Attachments
(1 file, 1 obsolete file)
8.82 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
To complete the test case coverage :)
Assignee | ||
Comment 1•11 years ago
|
||
support "removeError" and "addError"
Assignee | ||
Comment 2•11 years ago
|
||
support "addError" and "removeError"
Attachment #8392141 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #8392142 -
Flags: review?(vyang)
Comment 3•11 years ago
|
||
Comment on attachment 8392142 [details] [diff] [review]
v1
Review of attachment 8392142 [details] [diff] [review]:
-----------------------------------------------------------------
I had concern about the execution time of this script. It already takes 20+ seconds on try server now [1] and we still want to add more. It seems fine because we have MARIONETTE_TIMEOUT set to 60 seconds, but I have seen some test cases take 2 or 3 times more than ordinary on try server. Please consider dividing this long script into smaller parts next time.
[1]: https://tbpl.mozilla.org/php/getParsedLog.php?id=36299120&tree=B2g-Inbound&full=1
::: dom/telephony/test/marionette/test_conference.js
@@ +680,5 @@
> + let outInfo = OutCallStrPool(outNumber);
> + let inInfo = InCallStrPool(inNumber);
> + let inInfo2 = InCallStrPool(inNumber2);
> + let inInfo3 = InCallStrPool(inNumber3);
> + let inInfo4 = InCallStrPool(inNumber4);
nit: these functions shouldn't have their first letters capital.
Attachment #8392142 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•