984318 - [B2G] [Emulator] correct MAX_CALLS (on gsm)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Considering gsm network, we could have at maximum one single call and one conference call (up to 5 participants) at the same time. So MAX_CALLS should be 6.

Comment 1

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Attachment: PR

Comment 2

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Correct my comment0.

According to TS 22.030 clause 6.5.5.6, it implies that there could be up to 6 (active+held) calls plus one incoming call. So, MAX_CALLS shouldn't be 6, at least 7.

But I realized that TS 22.135 seems have a different definition that points out a different maximum number. I'll investigate and get back later. Thanks!

Comment 3

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Thank to discussion with Shawn :)

3gpp 22.083, clause 2.2.1, 
"The served mobile subscriber can only have one call on hold at a time."

3gpp 22.084, clause 1.2.1,
"The maximum number of remote parties is 5."

3gpp 22.030, clause 6.5.5.6,
"Provided both Call Hold and Call Waiting is active, it is possible to have one active and one held call and then a third call attempting to make contact."

According to above 3, we know the max case is "there comes an incoming call, when we have one active(held) concall (with 5 remote parties) and one held(active) single call." The max number is 7.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8392140 [details] [review]
PR

Please comment the magic number 7.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Merged on Github:
https://github.com/mozilla-b2g/platform_external_qemu/commit/0f9f3d948d6ba25c47fbec29e2eff02c8590e2e2
Test cases are available in bug 984289.