98440 - text selection lockup/memory leak

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[Artem Saveliev]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.3) Gecko/20010801
BuildID:    20010905

Total lockup when selecting text.


Reproducible: Always
Steps to Reproduce:
1. Go to http://www.ayna.com/index.utf8.html
2. Press on and hold mouse button
3. Start selecting text randomly

Actual Results:  Mozilla loads 100% CPU and starts eating RAM almost instantly.

Expected Results:  Selection works correctly, at least when RTL selection bug
will be fixed.

Comment 1

[kurros (Wade Majors)]

I can confirm this here with the 20010905 daily under win32. I can't find a
releveant dupe at the moment, but I recall seeing this posted before. Anyone?

Comment 2

[Simon Montagu :smontagu]

I think this has something to do with a checkin by mjudge. 

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/layout/html/base/src/nsFrame.cpp

The log for rev 3.315 refers to bug 82993 and bug 87662, but there are changes
in the bidi additions to |nsFrame::GetFrameFromDirection| that don't seem to
even be in the diffs attached to those bugs.

What are those changes about? I think that moving the test for |if
(!selectable)| inside the |while| is causing an infinite loop here.

Comment 3

[Simon Montagu :smontagu]

Attachment: suggested patch

Comment 4

[Simon Montagu :smontagu]

Attachment 48844 [details] [diff] backs out the change I mentioned in my previous comment© With
this patch applied I no longer experience the lockup©

mjudge: what will this break?

Comment 5

[Simon Montagu :smontagu]

apologies for the spam - reassigning owner and QA because of strange behaviour
by Bugzilla

Comment 6

[mjudge]

i am looking to see what this will break. gimme a min to get back to you

Comment 7

[mjudge]

I am pulling a tree right now. I would like to try this patch out myself. is 
that ok or do you need an answer like right away?

MJ

Comment 8

[Simon Montagu :smontagu]

Go ahead, I am happy to wait while you investigate to your satisfaction.

Comment 9

[Simon Montagu :smontagu]

Upgrading severity and nominating, since this is a hanger. mjudge: any thoughts?

Comment 10

[Simon Montagu :smontagu]

I think this should have been fixed by the checkin to bug 76190 (and/or 82352),
but I can't reproduce the hang in builds either before or after that checkin.
Can you retest?

Comment 11

[Samir Gehani]

adt: nsbeta1-

Comment 12

[Ari Pollak]

I'm not seeing this in mozilla 1.7 on Linux. Does it still happen on Windows?

Comment 13

[Artem Saveliev]

does not happen in mozilla 1.6 on windows 2003 server, that i use now.
anything about other OSes?

Comment 14

[Eyal Rozenberg]

Also not seeing this bug at the moment with build 2004-06-20 and Windows XP.

Comment 15

[Simon Montagu :smontagu]

Resolving WORKSFORME per last few comments.

Comment 16

[Ari Pollak]

well, does it work on Windows 2000?