984486 - expect "email" to be primary key for FxA data returned from Gecko, falling back to "accountId"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Sam Penrose]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=981210#c3, take one step towards unifying the FxA data to be keyed on "email" by editing FxAccountsIACHelper and friends to look for email and fall back to accountId. Once Gaia can handle either, we can land 981210 to use only email, and then we can remove the fallback logic. Jared LMK if you'd rather I take this.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Right now, Settings can handle either:

menu item code: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/firefox_accounts/menu.js#L30-L32

panel code: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/firefox_accounts/panel.js#L58-L60

But System cannot:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/fxa/js/fxam_server_request.js#L24

Fixing this presently, I'll get a PR out.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Also I don't see any reference to accountId anywhere inside the FTU app (apps/communications), so I think this system app is the only spot affected.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 18093

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8403693 [details] [review]
Github PR 18093

ferjm - mind taking a look? This change allows 'email' or 'accountId' as the response within the system app. Travis is green.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/b308c4b7c8ed56d922d3dddadeeb718e3fb3a553