98451 - Clean up globals.pl/CGI.pl mess.

Status: RESOLVED DUPLICATE of bug 87411

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Matthew Tuck [:CodeMachine]]

The globals and CGI files have become a mess.  They are too big, and
interdependent.

We should separate them into clearly defined files with no cycles.  My
suggestion is as follows:

utilities - this stuff is at the base and is general stuff useful throughout
bugzilla and probably other applications as well

database - may depend on utilities, handles all generic database handling - sql
stuff, database independence, shadow database logic, non-database system
parameters

bugs
users
groups
admin - General files, each relying on utilities and databases.  Things hanging
off bugs like votes and attachments go into bugs.  May have dependencies between
each other but no cycles.

application-general - General application logic - footers, system messages,
error messages.   Relies on the above files.

Comment 1

[Matthew Tuck [:CodeMachine]]

Let's try to do this near the end of 2.15 when the patch queue is clearer.

Comment 2

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 3

[Jacob Steenhagen]

*** Bug 122891 has been marked as a duplicate of this bug. ***

Comment 4

[Jacob Steenhagen]

These should be .pm files, not .pl and we should strive to use CGI.pm (the one
that comes with perl) instead of the current $::FORM stuff.

Comment 5

[Bradley Baetz (:bbaetz)]

I'll do DB.pm, which will dynamically use DB::$dbtype.pm once I work out how.

Comment 6

[Gervase Markham [:gerv]]

Does this bug actually have any use? It's not a tracking bug, and it seems all
the things it might cover are in other bugs or in people's minds.

Gerv

Comment 7

[Dave Miller [:justdave]]

yep.

Comment 8

[Dave Miller [:justdave]]

Actually, I take that back, this is a dupe.  I just didn't do real good finding
it on the first attempt :)

*** This bug has been marked as a duplicate of 87411 ***