Closed
Bug 985207
Opened 10 years ago
Closed 9 years ago
getTitle should return the top level browsing context title
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: automatedtester, Assigned: joshin4colours, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: pi-marionette-server, pi-marionette-spec, Whiteboard: [good first bug][lang=js][marionette=1.0])
Attachments
(2 files, 1 obsolete file)
Currently getTitle appears to suffer from the same issue as in bug 977893 so we should fix that. Raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=25095 to get this documented too.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [good first bug][lang=js][mentor=automatedtester]
Reporter | ||
Updated•10 years ago
|
Whiteboard: [good first bug][lang=js][mentor=automatedtester] → [good first bug][lang=js][mentor=automatedtester][spec]
Reporter | ||
Updated•10 years ago
|
Keywords: ateam-marionette-spec
Reporter | ||
Comment 1•10 years ago
|
||
We will need to update http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#164. It doesnt need to make a call over to marionette-listener. We just need to get the browser object and check what the title is.
Whiteboard: [good first bug][lang=js][mentor=automatedtester][spec] → [good first bug][lang=js][mentor=automatedtester]
Comment 2•10 years ago
|
||
Have you meant that the fix should be done in marionette-server.js and should be similar to your fix for current url - https://bugzilla.mozilla.org/attachment.cgi?id=8393227&action=diff
Updated•10 years ago
|
Mentor: dburns
Whiteboard: [good first bug][lang=js][mentor=automatedtester] → [good first bug][lang=js]
Comment 3•10 years ago
|
||
(In reply to botalov.andrey from comment #2) > Have you meant that the fix should be done in marionette-server.js and > should be similar to your fix for current url - > https://bugzilla.mozilla.org/attachment.cgi?id=8393227&action=diff
Flags: needinfo?(dburns)
Reporter | ||
Comment 4•10 years ago
|
||
Andrey, Sorry I missed your message. The fix needs to be done in marionette-server.js and there will be tests that need updating
Flags: needinfo?(dburns)
Reporter | ||
Comment 5•10 years ago
|
||
The fix should be in http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#1150. Instead of doing a call to this.sendAsync we should update it to be something along the lines of https://bugzilla.mozilla.org/attachment.cgi?id=8393227&action=diff but needs to get the top level document title.
Assignee: nobody → n.n.nachiketh
Can you tell me what top level browsing context title means, also how is it different from what it does now?
Reporter | ||
Updated•9 years ago
|
Whiteboard: [good first bug][lang=js] → [good first bug][lang=js][marionette=1.0]
Reporter | ||
Updated•9 years ago
|
Assignee: n.n.nachiketh → nobody
Reporter | ||
Updated•9 years ago
|
Priority: -- → P1
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → joshua.m.grant
Comment 7•9 years ago
|
||
doing a drive by here, Josh, do you need further information to work on this bug? No question is too simple!
Flags: needinfo?(joshua.m.grant)
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #7) > doing a drive by here, Josh, do you need further information to work on this > bug? No question is too simple! Thanks for letting me know! I just got some setup stuff worked out, so I'll let you know if I need any details.
Flags: needinfo?(joshua.m.grant)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
Keywords: ateam-marionette-server
Assignee | ||
Comment 9•9 years ago
|
||
I have pushed changes to reviewboard, here: https://reviewboard.mozilla.org/r/4763/diff/0 but these chanages may have become attached to the wrong bug?
Reporter | ||
Comment 10•9 years ago
|
||
It looks like you might be using the same bookmark as you were for the previous bugs. Can you create a new bookmark from inbound and then push that new bookmark to reviewboard
Assignee | ||
Comment 11•9 years ago
|
||
/r/6095 - Bug 985207 updated getTitle Pull down this commit: hg pull review -r 1b4b85d1c589ef3b6785745288356179c8476de6
Attachment #8583287 -
Flags: review?(dburns)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8583287 [details] MozReview Request: bz://985207/joshin4colours /r/6095 - Bug 985207 updated getTitle /r/6369 - Bug 985207 fixup for line-ending syntax error Pull down these commits: hg pull review -r 8e3fa7b5d472aa7fa676c5e5d3e88c0f6b1decb0
Comment 13•9 years ago
|
||
This needs to be rebased.
Reporter | ||
Comment 14•9 years ago
|
||
Comment on attachment 8583287 [details] MozReview Request: bz://985207/joshin4colours https://reviewboard.mozilla.org/r/6093/#review5321 ::: testing/marionette/marionette-server.js (Diff revision 2) > +"use strict"; This file no longer exists so this patch needs a rebase
Attachment #8583287 -
Flags: review?(dburns)
Reporter | ||
Comment 15•9 years ago
|
||
This appears to have been inadvertantly fixed in the mozilla refactor so am closing. Sorry about that Josh, I am sure there are other bugs we can find for you.
Assignee | ||
Comment 16•9 years ago
|
||
No problem David, thanks for letting me know :)
Reporter | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•9 years ago
|
||
Attachment #8583287 -
Attachment is obsolete: true
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•