Closed Bug 985291 Opened 9 years ago Closed 7 years ago

Always use hash instead of build ID for cachebusting favicons, CSS, and JS

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: cvan, Unassigned)

References

()

Details

(Keywords: perf, Whiteboard: [ktlo][possible_future_need])

1. When we deploy to production, our fabfile runs `commonplace includes`.
2. This writes to a file called `build_id.txt` a numeric timestamp.
3. Zamboni uses this timestamp to cachebust our favicons, stylesheets, and scripts (which are served from our CDN and have a `Cache-Control` `max-age` of 10 years). See view-source:https://marketplace.firefox.com/
4. If a resource hasn't changed, we still refetch the resource because the URL is different.

There are times (seldomly, albeit) when our stylesheets or scripts haven't changed. The favicons and splash screen change almost never. The main stylesheet and main JS bundle - those are almost guaranteed to have changed every push.

Anyway, we shouldn't be blindly cachebusting things if the content hasn't changed, like this one for example:

    https://marketplace.cdn.mozilla.net/media/fireplace/img/logos/128.png?b=1395166222469
See Also: → 985290
See Also: → 985292
See Also: → 985293
Keywords: perf
No longer blocks: tarako-marketplace
Blocks: 992365
No longer blocks: 992365
See Also: → 1074474
See Also: → 1083185
Whiteboard: [ktlo]
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Whiteboard: [ktlo] → [ktlo][possible_future_need]
You need to log in before you can comment on or make changes to this bug.