985387 - Loop Server — A new registration to an existing User Device (login) should add a new SimplePush URL if it is not already stored

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Comment 1

[Rémy Hubscher (:natim)]

Well actually, there is two things :
 - For now, we handle only a Simple Push URL per user (since user are cookies based)
 - We want to manage a Simple Push URL per User Device (assuming we are using FxA or MSISDN for logging.

Comment 2

[Alexis Metaireau (:alexis)]

there is actually no reason that we have only one simple push url per user. Even with sessions, we could have more than one simple push url if needed.

This will let us have multiple simple push urls per user for free as soon as we activate a different authentication scheme.

Comment 3

[Rémy Hubscher (:natim)]

Well we still need to define how we can identify user devices then because we want to store a simple push url per user device.

Comment 4

[Alexis Metaireau (:alexis)]

Yes, that's true. And that's why it could make sense to have the client sending us an unique ID it generates when starting up loop for the first time.

Adam, any feedback about that?

Comment 5

[Adam Roach [:abr]]

(In reply to Alexis Metaireau (:alexis) from comment #4)
> Yes, that's true. And that's why it could make sense to have the client
> sending us an unique ID it generates when starting up loop for the first
> time.
> 
> Adam, any feedback about that?

Yes, once we go to account-based identification, we're going to want endpoint identifiers for managing push URLs. So, where the current schema contains a single push URL, and Fernando's proposed schema contains a list of push URLs (possibly with attached attributes), what we really want is something that maps from an endpoint ID to its associated push URL (this is, as far as I can tell, basically what you're proposing).

Comment 6

[Alexis Metaireau (:alexis)]

Attachment: link to github PR

Comment 7

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/98ff56eed1c3cf248701beb5e5059bd61e8059b9

Comment 8

[James Bonacci [:jbonacci]]

Verified in code and unit tests.