9854 - [malloc] memory allocation problems - oji

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P3)

Description

[chris hofmann]

malloc] memory allocation problems - oji

check bug 8227 for more details on what needs to be done to this code

s:/mozilla/modules/oji/src/jvmmgr.cpp
   Deref-error: "securityContext", line 518
s:/mozilla/modules/oji/src/lcglue.cpp
   Deref-error: "pSecInfoNew", line 371
   Deref-error: "pSecInfoNew", line 372
   Deref-error: "pSecInfoNew", line 373
   Deref-error: "pSecInfoNew", line 374
   Deref-error: "pSecInfoNew", line 375
   Deref-error: "pSecInfoNew", line 377
   Deref-error: "pSecInfoNew", line 378
   Deref-error: "pSecInfoNew", line 385
   Deref-error: "pSecInfoNew", line 386
s:/mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp
   Deref-error: "peer", line 1870
   Deref-error: "pluginTag", line 2235
   Deref-error: "pluginTag", line 2240
   Deref-error: "pluginTag", line 2241
   Deref-error: "pluginTag", line 2242
   Deref-error: "pluginTag", line 2243
   Deref-error: "pluginTag", line 2244
   Deref-error: "pluginTag", line 2245
   Deref-error: "pluginTag", line 2246
   Deref-error: "pluginTag", line 2247
   Deref-error: "pluginTag", line 2248
   Deref-error: "pluginTag", line 2249
   Deref-error: "pluginTag", line 2252
   Deref-error: "pluginTag", line 2253
   Deref-error: "pluginTag", line 2254

Comment 1

[chris hofmann]

move to m14. let me know if fixes are available. thx.

Comment 2

[edburns]

Attachment: Patch to fix this bug

Comment 3

[Bruce Mitchener]

Looks okay to me. r=bruce ... I'd look into the use of the raw AddRef() and
Release() methods and see if there's a reason that code isn't using NS_ADDREF()
and NS_RELEASE().

Comment 4

[edburns]

I'm going to leave the AddRef() as is and clean it up, along with other XPCOM 
no-nos later.

Comment 5

[edburns]

Checked in fix.

Comment 6

[Paul Wyskoczka]

Verified per programmer's comments.