985476 - [FxA][l10n][1.4] back out Firefox Account specific strings from 1.4

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Axel Hecht [:Pike]]

Sadly, we don't support any optional or preffed-on/off strings in the l10n files.

As we're disabling FxA on 1.4 (per IRC), can we back out the strings?

This would be 1.4 only.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: gaia pull request 17329

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8393524 [details] [review]
gaia pull request 17329

I think this is gonna break the UI, at least for the js-hooked-up pieces.

How are we going to switch this off for 1.4? Do we know that yet?

Comment 3

[Preeti Raghunath(:Preeti)]

Lets get the additional strings backed out

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8393524 [details] [review]
gaia pull request 17329

Easy one ;)

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

RyanVM - note this one is headed to 1.4 only, not master

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Axel Hecht [:Pike] from comment #2)
> Comment on attachment 8393524 [details] [review]
> gaia pull request 17329
> 
> I think this is gonna break the UI, at least for the js-hooked-up pieces.
> 
> How are we going to switch this off for 1.4? Do we know that yet?

We discussed this on IRC a bit this morning, but just to overcommunicate in the bug, there's a pref (identity.fxaccounts.ui.enabled) which is set to false by default. The FTU code doesn't display the firefox accounts screen if this pref is false, so I think merging this patch should have no adverse effects.

Does that answer your questions, Pike?

Comment 7

[Axel Hecht [:Pike]]

Yes, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v1.4: c0318e9dcafc13dc17869b1f83e1032ab5d2b07c