Closed Bug 985537 Opened 6 years ago Closed 6 years ago

[B2G] add runEmulatorShell to Marionette

Categories

(Testing :: Marionette, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:-, firefox29 wontfix, firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
mozilla31
blocking-b2g -
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(1 file)

We have already runEmulatorCmd, which executes a string command in emulator console through telnet.  However, that means you need to commit some changes to "external/qemu/android/console.c" in order to add new commands.  It will be very handy if we allow executing arbitrary commands through "adb shell" and then we can examine the response without touching one line in qemu source.
Attached patch patchSplinter Review
Hi Malini Das, may I have your review?
Assignee: nobody → vyang
Attachment #8393594 - Flags: review?(mdas)
Comment on attachment 8393594 [details] [diff] [review]
patch

Review of attachment 8393594 [details] [diff] [review]:
-----------------------------------------------------------------

This looks really good, thanks!
Attachment #8393594 - Flags: review?(mdas) → review+
Hi, after some more thoughts, this shouldn't be named as runEmulatorShell because it's common to all adb-enabled devices.  runEmulatorCmd is emulator specific because only emulator has that telnet service.  I think I should have named it as runAdbShell.  How do you think?
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> Hi, after some more thoughts, this shouldn't be named as runEmulatorShell
> because it's common to all adb-enabled devices.  runEmulatorCmd is emulator
> specific because only emulator has that telnet service.  I think I should
> have named it as runAdbShell.  How do you think?

Sorry, after some more deep diving into Marionette source code, that doesn't work because we don't have anything abstracting ADB in class Marionette when its |self.emulator| is not defined.  So let's take that reviewed patch.
https://hg.mozilla.org/mozilla-central/rev/2a33822ea94b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 990383
Nominate for 1.4: The test case of bug 990383 needs this marionette command.
blocking-b2g: --- → 1.4?
Has automatic approval. No need to request approval here
blocking-b2g: 1.4? → -
You need to log in before you can comment on or make changes to this bug.