985537 - [B2G] add runEmulatorShell to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

We have already runEmulatorCmd, which executes a string command in emulator console through telnet.  However, that means you need to commit some changes to "external/qemu/android/console.c" in order to add new commands.  It will be very handy if we allow executing arbitrary commands through "adb shell" and then we can examine the response without touching one line in qemu source.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Hi Malini Das, may I have your review?

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

https://tbpl.mozilla.org/?tree=Try&rev=c75572eb0d61

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8393594 [details] [diff] [review]
patch

Review of attachment 8393594 [details] [diff] [review]:
-----------------------------------------------------------------

This looks really good, thanks!

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Hi, after some more thoughts, this shouldn't be named as runEmulatorShell because it's common to all adb-enabled devices.  runEmulatorCmd is emulator specific because only emulator has that telnet service.  I think I should have named it as runAdbShell.  How do you think?

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> Hi, after some more thoughts, this shouldn't be named as runEmulatorShell
> because it's common to all adb-enabled devices.  runEmulatorCmd is emulator
> specific because only emulator has that telnet service.  I think I should
> have named it as runAdbShell.  How do you think?

Sorry, after some more deep diving into Marionette source code, that doesn't work because we don't have anything abstracting ADB in class Marionette when its |self.emulator| is not defined.  So let's take that reviewed patch.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2a33822ea94b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a33822ea94b

Comment 8

[Edgar Chen [:edgar]]

Nominate for 1.4: The test case of bug 990383 needs this marionette command.

Comment 9

[Preeti Raghunath(:Preeti)]

Has automatic approval. No need to request approval here

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/102de3568ed5