990383 - [B2G] [RIL] consider to set default value of 'supportedNetworkTypes' as 'wcdma/gsm'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We now use World phone as the default value of supportedNetworkTypes. According to the fact the number of wcdma/gsm phones is larger than world phones, maybe we should use 'wcdma/gsm' instead.

Comment 1

[Edgar Chen [:edgar]]

Before we change the default value, emulator needs to be configured with correct value first, otherwise the test case will fail.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8399857 [details] [diff] [review]
Patch, v1

Review of attachment 8399857 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Hi Hsinyi,

In this new version, I modify the test case to make it more robust.
1). Get system property configuration by "runEmulatorShell" which was introduced in bug 985537. (The default value will be the same as the one defined in ril_consts.js)
2). Running the tests based on the configuration.

Thank you

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8400437 [details] [diff] [review]
Patch, v2

Review of attachment 8400437 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobileconnection/tests/marionette/test_mobile_preferred_network_type.js
@@ +70,2 @@
>  
> +  getSupportedNetworkTypesFromSystemProperties(0, function(testData) {

Truly nice! Thank you :)

Comment 6

[Edgar Chen [:edgar]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=42d6fa3e7a8f

Comment 7

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d878334f3121

Comment 8

[Edgar Chen [:edgar]]

For 1.4 branch, we need uplift bug 985537 first.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d878334f3121

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e277c405f066