Closed Bug 985687 Opened 6 years ago Closed 6 years ago

Remove last vestiges of shortid/tinyid

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Followup to bug 797126.  With this, there are no more mentions of either string in js/src.

The parser already complains if you have too many variables in a scope, when you hit the limit storable in a pn_cookie.  No need to do any limit-testing after that.

The test loop-limits are somewhat arbitrary.  But we can't make them too big without hitting platform-specific OOM or timeouts or whatever.
Attachment #8393772 - Flags: review?(luke)
Comment on attachment 8393772 [details] [diff] [review]
Patch

Wow, cool.  How did I miss tinyid :)
Attachment #8393772 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/30e6959192db

"...And I started jumping up and down yelling, 'KILL, KILL!', and he started jumping up and down with me and we was both jumping up and down yelling, 'KILL, KILL!'..."

https://www.youtube.com/watch?v=m57gzA2JCcM
https://hg.mozilla.org/mozilla-central/rev/02a433dbb824
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.