985687 - Remove last vestiges of shortid/tinyid

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Followup to bug 797126.  With this, there are no more mentions of either string in js/src.

The parser already complains if you have too many variables in a scope, when you hit the limit storable in a pn_cookie.  No need to do any limit-testing after that.

The test loop-limits are somewhat arbitrary.  But we can't make them too big without hitting platform-specific OOM or timeouts or whatever.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 8393772 [details] [diff] [review]
Patch

Wow, cool.  How did I miss tinyid :)

Comment 2

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30e6959192db

"...And I started jumping up and down yelling, 'KILL, KILL!', and he started jumping up and down with me and we was both jumping up and down yelling, 'KILL, KILL!'..."

https://www.youtube.com/watch?v=m57gzA2JCcM

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/02a433dbb824