Closed
Bug 797126
Opened 12 years ago
Closed 10 years ago
Remove tinyid/shortid
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: evilpie, Assigned: luke)
References
Details
Attachments
(1 file)
93.09 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
I do not like these, but I suspect this might be some work to remove all the uses.
Assignee | ||
Comment 3•10 years ago
|
||
Assignee: general → luke
Attachment #8379323 -
Flags: review?(terrence)
Comment 4•10 years ago
|
||
Comment on attachment 8379323 [details] [diff] [review] rm-shortid Review of attachment 8379323 [details] [diff] [review]: ----------------------------------------------------------------- Epic! r=me ::: js/src/jsapi.cpp @@ +3166,5 @@ > return nullptr; > > RootedValue nobjValue(cx, ObjectValue(*nobj)); > + if (!DefineProperty(cx, obj, name, nobjValue, GetterWrapper(nullptr), SetterWrapper(nullptr), > + attrs, 0)) { { on newline. ::: js/src/jsonparser.cpp @@ +594,5 @@ > for (size_t i = 0; i < properties.length(); i++) { > propid = properties[i].id; > value = properties[i].value; > + if (!DefineNativeProperty(cx, obj, propid, value, JS_PropertyStub, JS_StrictPropertyStub, > + JSPROP_ENUMERATE, 0)) { { on newline.
Attachment #8379323 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 5•10 years ago
|
||
I thought the style was that { goes on the newline only when it improves clarity (e.g., with if (blah && stuff) { stmt; } I'd want to put the { on a new line but, with the two statements in question, that's not the case.
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6cf2d7996a4
Comment 7•10 years ago
|
||
\o/
https://hg.mozilla.org/mozilla-central/rev/a6cf2d7996a4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•