797126 - Remove tinyid/shortid

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Luke Wagner [:luke]]

I do not like these, but I suspect this might be some work to remove all the uses.

Comment 3

[Luke Wagner [:luke]]

Attachment: rm-shortid

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8379323 [details] [diff] [review]
rm-shortid

Review of attachment 8379323 [details] [diff] [review]:
-----------------------------------------------------------------

Epic! r=me

::: js/src/jsapi.cpp
@@ +3166,5 @@
>          return nullptr;
>  
>      RootedValue nobjValue(cx, ObjectValue(*nobj));
> +    if (!DefineProperty(cx, obj, name, nobjValue, GetterWrapper(nullptr), SetterWrapper(nullptr),
> +                        attrs, 0)) {

{ on newline.

::: js/src/jsonparser.cpp
@@ +594,5 @@
>      for (size_t i = 0; i < properties.length(); i++) {
>          propid = properties[i].id;
>          value = properties[i].value;
> +        if (!DefineNativeProperty(cx, obj, propid, value, JS_PropertyStub, JS_StrictPropertyStub,
> +                                  JSPROP_ENUMERATE, 0)) {

{ on newline.

Comment 5

[Luke Wagner [:luke]]

I thought the style was that { goes on the newline only when it improves clarity (e.g., with
  if (blah &&
      stuff) {
      stmt;
  }
I'd want to put the { on a new line but, with the two statements in question, that's not the case.

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6cf2d7996a4

Comment 7

[Bobby Holley (:bholley)]

\o/

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a6cf2d7996a4