Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: evilpie, Assigned: luke)

Tracking

Trunk
mozilla30
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
I do not like these, but I suspect this might be some work to remove all the uses.
Duplicate of this bug: 914433
Depends on: 975069
Depends on: 975162
Posted patch rm-shortidSplinter Review
Assignee: general → luke
Attachment #8379323 - Flags: review?(terrence)
Comment on attachment 8379323 [details] [diff] [review]
rm-shortid

Review of attachment 8379323 [details] [diff] [review]:
-----------------------------------------------------------------

Epic! r=me

::: js/src/jsapi.cpp
@@ +3166,5 @@
>          return nullptr;
>  
>      RootedValue nobjValue(cx, ObjectValue(*nobj));
> +    if (!DefineProperty(cx, obj, name, nobjValue, GetterWrapper(nullptr), SetterWrapper(nullptr),
> +                        attrs, 0)) {

{ on newline.

::: js/src/jsonparser.cpp
@@ +594,5 @@
>      for (size_t i = 0; i < properties.length(); i++) {
>          propid = properties[i].id;
>          value = properties[i].value;
> +        if (!DefineNativeProperty(cx, obj, propid, value, JS_PropertyStub, JS_StrictPropertyStub,
> +                                  JSPROP_ENUMERATE, 0)) {

{ on newline.
Attachment #8379323 - Flags: review?(terrence) → review+
I thought the style was that { goes on the newline only when it improves clarity (e.g., with
  if (blah &&
      stuff) {
      stmt;
  }
I'd want to put the { on a new line but, with the two statements in question, that's not the case.
https://hg.mozilla.org/mozilla-central/rev/a6cf2d7996a4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Blocks: 985687
You need to log in before you can comment on or make changes to this bug.