985710 - turn off js/src/config/milestone.txt bumping for tb beta + add comment in esr24

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Comment 1

[Aki Sasaki (not active)]

Attachment: release

In the postmortem, we decided that not bumping js/src/config/milestone.txt for a chemspill would be less of an issue than trying to bump a nonexistent js/src/config/milestone.txt when 29.0 build 1 rolls around.

Comment 2

[Aki Sasaki (not active)]

Attachment: esr24

The same may or may not be true for esr24.  If we create the esr31 config from the release config, we'd be good without this patch.  If we create the esr31 config from esr24, it would be best to have this patch landed beforehand.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8393799 [details] [diff] [review]
esr24

How about we do this instead:

diff --git a/mozilla/release-firefox-mozilla-esr24.py.template b/mozilla/release-firefox-mozilla-esr24.py.template
--- a/mozilla/release-firefox-mozilla-esr24.py.template
+++ b/mozilla/release-firefox-mozilla-esr24.py.template
@@ -43,6 +43,7 @@ releaseConfig['nextMilestone']       = r
 #  Repository configuration, for tagging
 releaseConfig['sourceRepositories']  = {
     'mozilla': {
+        # XXX remove js/src/config/milestone.txt when setting up ESR31
         'name': 'mozilla-esr24',
         'path': '{{ branch }}',
         'revision': '{{ mozillaRevision }}',

Then the person cloning the config for ESR31 will have a comment right under their nose.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8393797 [details] [diff] [review]
release

The same patch is on bug 984214, the next migration tracking bug. The person handling the merge to m-r should pick it up there.

Comment 5

[Aki Sasaki (not active)]

Attachment: esr24 + thunderbird beta

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 8393892 [details] [diff] [review]
esr24 + thunderbird beta

https://hg.mozilla.org/build/buildbot-configs/rev/fa444c5461de

Comment 7

[Jordan Lund (:jlund)]

something checked-in went into production :)