9860 - [malloc] memory allocation problems - silentdl

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[chris hofmann]

[malloc] memory allocation problems - silentdl

check bug 8227 for more details on what needs to be done to this code

s:/mozilla/silentdl/nsSilentDownload.cpp
   Deref-error: "outFileLocation", line 159
   Deref-error: "outFileLocation", line 163
   Deref-error: "outFileLocation", line 166

Comment 1

[Daniel Veditz [:dveditz]]

Reassigning to Doug, this is his area. But I think this feature has been pulled
for Seamonkey. Do we leave the code in the tree so it doesn't bitrot, turn it
off so it won't keep showing up when people run purify-like tools, or fix the
leak now?

Comment 2

[Doug Turner (:dougt)]

it is a simple fix to avoid these warning.  In fact, I am not really sure why
these would be reported as error.  Here is the diff which should fix these
messages:

Index: nsSilentDownload.cpp
===================================================================
RCS file: /cvsroot/mozilla/silentdl/nsSilentDownload.cpp,v
retrieving revision 1.16
diff -c -4 -r1.16 nsSilentDownload.cpp
*** nsSilentDownload.cpp	1999/05/10 05:34:24	1.16
--- nsSilentDownload.cpp	1999/07/14 20:17:14
***************
*** 144,171 ****

  nsFileSpec *
  CreateOutFileLocation(const nsString& url, const nsString& directory)
  {
!     nsSpecialSystemDirectory *outFileLocation =
!         new
nsSpecialSystemDirectory(nsSpecialSystemDirectory::OS_CurrentProcessDirectory);

-     //*outFileLocation += directory;
-
      PRInt32 result = url.RFind('/');
      if (result != -1)
      {
          nsString fileName;
          url.Right(fileName, (url.Length() - result) );
!         *outFileLocation += fileName;
      }
      else
      {
!         *outFileLocation += "sdl";
      }

!     outFileLocation->MakeUnique();

!     return outFileLocation;
  }



--- 144,168 ----

  nsFileSpec *
  CreateOutFileLocation(const nsString& url, const nsString& directory)
  {
!     nsSpecialSystemDirectory
outFileLocation(nsSpecialSystemDirectory::OS_CurrentProcessDirectory);

      PRInt32 result = url.RFind('/');
      if (result != -1)
      {
          nsString fileName;
          url.Right(fileName, (url.Length() - result) );
!         outFileLocation += fileName;
      }
      else
      {
!         outFileLocation += "sdl";
      }

!     outFileLocation.MakeUnique();

!     return new nsSpecialSystemDirectory(outFileLocation);
  }

I will check it in when the tree opens.

Comment 3

[Doug Turner (:dougt)]

this has been checked in.  I am closing 9860.

Comment 4

[leger]

Bulk move from Silent Download (this component to be deleted) to Installer.