986223 - Test server startup / shutdown on b2g

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Via the gaia-integration suite, we can expand our b2g server-side coverage.

As a simple case to begin with, let's ensure the debugger server can start at all.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Test Dev Tools server toggling

Vivien, this is the first in a series of tests I'd like to add so we can ensure the Dev Tools server is working correctly on b2g devices (with full Gaia running, etc.).

Assuming this approach is okay, I'll add more tests like this in future for specific features.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try is green: https://tbpl.mozilla.org/?tree=Try&rev=ab37f8a7494

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

I have been told that ochameau wants to do this review :)

Comment 4

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

I would like us (devtools team) to have one folder of ours in gaia,
so even if I do the review of this patch, I'd like a formal approval of this approach. See my comment in the pull request.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

(In reply to Alexandre Poirot (:ochameau) from comment #4)
> Comment on attachment 8395739 [details] [review]
> Test Dev Tools server toggling
> 
> I would like us (devtools team) to have one folder of ours in gaia,
> so even if I do the review of this patch, I'd like a formal approval of this
> approach. See my comment in the pull request.

I asked for a devtools/ folder to Jan a few hours ago!

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #5)
> I asked for a devtools/ folder to Jan a few hours ago!

Where does this folder go?  Are you saying:

* /devtools (at the root of Gaia)

From your discussion[1] with Jan, maybe you are saying:

* /apps/system/devtools (with its own test directories under this)

or are you supporting one of Alex's ideas specific to tests:

* /apps/system/test/marionette/shell/devtools
* /tests/integration/devtools

[1]: https://github.com/mozilla-b2g/gaia/pull/17375#discussion_r10974844

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

/tests/integration/devtools please.

Do not put anything in System app.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, I've updated the PR to use the new path Tim suggested.

Comment 9

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

Looks good to me, it would really benefit from running the test script in the chrome process instead of remote, in node... But that's so great to finally have such tests!!!


Gareth, just to let you know, we are hacking into marionette tests.
Is that the only thing we have to modify to add a new folder for test scripts?

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8395739 [details] [review]
Test Dev Tools server toggling

Very cool!

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, I believe we've now gotten all the needed reviews.  Alex, can you merge this?  I guess I should eventually get access myself, if I'll be doing a lot of these...

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Alex, I've rebased the PR to fix conflicts.

Comment 13

[Alexandre Poirot [:ochameau] PTO, back August 11th]

https://github.com/mozilla-b2g/gaia/commit/3fa0b4ae576102724b263fe0be1d7b53da4e4944

Comment 14

[u279076]

Not sure what's appropriate here, in-testsuite?