Closed Bug 986234 Opened 6 years ago Closed 6 years ago

Thunderbird trunk build currently fails with "ERROR PROCESSING MOZBUILD FILE[...] ldap/moz.build The error appears to be part of the mozbuild.frontend.reader Python module itself!"

Categories

(Thunderbird :: Build Config, defect, blocker)

x86
All
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 31.0

People

(Reporter: mcsmurf, Assigned: clokep)

References

Details

(Keywords: regression)

Attachments

(2 files)

Starting with these changesets the Thunderbird trunk build does not build anymore:
https://hg.mozilla.org/comm-central/rev/12cc690d92b3
http://hg.mozilla.org/mozilla-central/rev/cf485c48b52f
http://hg.mozilla.org/projects/ldap-sdks/rev/2b72c62f5450

Error message from https://tbpl.mozilla.org/php/getParsedLog.php?id=36440321&tree=Thunderbird-Trunk&full=1#error0

Reticulating splines...
Traceback (most recent call last):
  File "./config.status", line 909, in <module>
    config_status(**args)
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\config_status.py", line 148, in config_status
    summary = the_backend.consume(definitions)
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\backend\base.py", line 186, in consume
    for obj in objs:
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\frontend\emitter.py", line 99, in emit
    for out in output:
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\frontend\reader.py", line 726, in read_mozbuild
    raise bre
mozbuild.frontend.reader.BuildReaderError: ==============================
ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file:

    c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/ldap/moz.build

The error appears to be part of the mozbuild.frontend.reader Python module itself! It is possible you have stumbled across a legitimate bug.

Traceback (most recent call last):
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\frontend\reader.py", line 722, in read_mozbuild
    descend=descend, metadata=metadata):
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\frontend\reader.py", line 762, in _read_mozbuild
    sandbox = MozbuildSandbox(config, path, metadata=metadata)
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\frontend\reader.py", line 164, in __init__
    mozpath.join(topobjdir, 'config.status'))
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\backend\configenvironment.py", line 157, in from_config_status
    config = BuildConfig.from_config_status(path)
  File "c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mozilla\python\mozbuild\mozbuild\backend\configenvironment.py", line 47, in from_config_status
    exec(code, g, l)
  File "c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/objdir-tb/config.status", line 32, in <module>
    substs = map(remap_subst, mozbuildcfg.substs)
  File "c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/objdir-tb/config.status", line 22, in remap_subst
    value = value.replace('$(DEPTH)', '$(DEPTH)/mozilla')
AttributeError: 'list' object has no attribute 'replace'
This is the file that causes the problem when getting executed (you can test yourself by doing "./config.status" on Linux in a Thunderbird objdir).
I think the checkin from Bug 979118 might be related here, though I'm not 100% sure: http://hg.mozilla.org/mozilla-central/rev/812c528dce3a
It added a new type of substitution rule which gets used inside config.status:
    (''' MMX_FLAGS ''', list(r''' -mmmx '''.split())),
    (''' SSE_FLAGS ''', list(r''' -msse '''.split())),
    (''' SSE2_FLAGS ''', list(r''' -msse2 '''.split())),

So I think remap_subst code inside config.status in comm-central needs to be fixed.
Depends on: 979118
I just did a hg bisect and agree that this checkin/bug is the problem.
Attached patch Potential fixSplinter Review
This gets me past configure (and is in the same vein as [1] for bug 935857). My build is running now.

[1] http://hg.mozilla.org/comm-central/rev/ea20d61fe85b
Attachment #8394502 - Flags: review?(Pidgeot18)
My build finished and seems to run successfully with this fix, I'm not 100% positive it's correct and I didn't break some sort of optimization.
Attachment #8394502 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/550064ca5ff6
Assignee: nobody → clokep
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.