Closed
Bug 9863
Opened 27 years ago
Closed 25 years ago
[malloc] memory allocation problems - beos code
Categories
(Core Graveyard :: Tracking, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chofmann, Assigned: ykoehler)
References
Details
Attachments
(2 files)
|
692 bytes,
patch
|
Details | Diff | Splinter Review | |
|
105.58 KB,
application/octet-stream
|
Details |
malloc] memory allocation problems - beos code
check bug 8227 for more details on what needs to be done to this code
s:/mozilla/widget/src/beos/nsAppShell.cpp
Deref-error: "app", line 101
s:/mozilla/widget/src/beos/nsFontRetrieverService.cpp
Deref-error: "fontInfo", line 186
Deref-error: "fontInfo", line 188
Deref-error: "fontInfo", line 189
s:/mozilla/widget/src/beos/nsMenuItem.cpp
Deref-error: "msg", line 183
s:/mozilla/widget/src/beos/nsToolkit.cpp
Deref-error: "ti", line 181
Deref-error: "ti", line 182
s:/mozilla/widget/src/beos/nsWindow.cpp
Deref-error: "w", line 505
Deref-error: "w", line 509
| Reporter | ||
Updated•27 years ago
|
Summary: malloc] memory allocation problems - beos code → [malloc] memory allocation problems - beos code
Updated•27 years ago
|
Assignee: mcafee → duncan
Comment 1•27 years ago
|
||
duncan
Comment 2•25 years ago
|
||
Please reassign this to Yannick Koehler. Duncan Wilcox is no longer on the
Mozilla for BeOS team.
The code in those files has been rewritten, and will have to be rechecked for
memory allocation problems.
| Assignee | ||
Comment 4•25 years ago
|
||
Here's patch that solve all the "beos" thingy on http://www.mozilla.org/projects/seamonkey/reports/memory-allocation-problems.txt
I've also used that time to correct the code so that there's less TABs (there's still is and that's acceptable as this is beos code !)
So the patch seems bigger than it should have been. As it only affect BeOS I'm going ahead with the commit.
Well... in doing a clean up, I actually forgot that commit was going to take all the files... so anyway the patch is also committed.
Status: NEW → ASSIGNED
| Assignee | ||
Comment 5•25 years ago
|
||
| Assignee | ||
Comment 6•25 years ago
|
||
| Assignee | ||
Comment 7•25 years ago
|
||
Had to put the second patch in a zip because I have removed files
nsMenuItem.cpp
nsMenuItem.h
nsMenu.cpp
nsMenu.h
nsMenuBar.cpp
nsMenuBar.h
nsDropTarget.cpp
This patch also try to remove a lot of tabs, To see the changes investigate the url mentionned above and check the related code. I mostly added if(varname) {} where needed and ensured that the {} were in the correct scope.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•