9863 - [malloc] memory allocation problems - beos code

Status: RESOLVED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[chris hofmann]

malloc] memory allocation problems - beos code

check bug 8227 for more details on what needs to be done to this code

s:/mozilla/widget/src/beos/nsAppShell.cpp
   Deref-error: "app", line 101
s:/mozilla/widget/src/beos/nsFontRetrieverService.cpp
   Deref-error: "fontInfo", line 186
   Deref-error: "fontInfo", line 188
   Deref-error: "fontInfo", line 189
s:/mozilla/widget/src/beos/nsMenuItem.cpp
   Deref-error: "msg", line 183
s:/mozilla/widget/src/beos/nsToolkit.cpp
   Deref-error: "ti", line 181
   Deref-error: "ti", line 182
s:/mozilla/widget/src/beos/nsWindow.cpp
   Deref-error: "w", line 505
   Deref-error: "w", line 509

Comment 1

[Chris McAfee]

duncan

Comment 2

[Matthew Zahorik]

Please reassign this to Yannick Koehler.  Duncan Wilcox is no longer on the 
Mozilla for BeOS team.

The code in those files has been rewritten, and will have to be rechecked for 
memory allocation problems.

Comment 3

[David Hallowell]

reassigning to Yannick...

Comment 4

[Yannick Koehler]

Here's patch that solve all the "beos" thingy on http://www.mozilla.org/projects/seamonkey/reports/memory-allocation-problems.txt

I've also used that time to correct the code so that there's less TABs (there's still is and that's acceptable as this is beos code !)

So the patch seems bigger than it should have been.  As it only affect BeOS I'm going ahead with the commit.

Well... in doing a clean up, I actually forgot that commit was going to take all the files... so anyway the patch is also committed.

Comment 5

[Yannick Koehler]

Attachment: Patch the nsBeOSMain.cpp inside webshell/tests/viewer

Comment 6

[Yannick Koehler]

Attachment: The rest... zip beos folder from widget/src/ only beos files

Comment 7

[Yannick Koehler]

Had to put the second patch in a zip because I have removed files 

nsMenuItem.cpp
nsMenuItem.h
nsMenu.cpp
nsMenu.h
nsMenuBar.cpp
nsMenuBar.h
nsDropTarget.cpp

This patch also try to remove a lot of tabs, To see the changes investigate the url mentionned above and check the related code.  I mostly added if(varname) {} where needed and ensured that the {} were in the correct scope.