986493 - WebApps.jsm imports a bunch of modules on startup

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Marco Bonardo [:mak]]

Doesn't look like all of the modules imported here are needed on startup (see bug 986323):

http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#36

For example AppDownloadManager.jsm or WebappOSUtils.jsm
I think these may use DefineLazyModuleGetter.

I didn't check what's using WebApps.jsm on startup, though it may be worth to verify what this module does when loaded since that happens.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Also WebappManager.jsm and NativeApp.jsm

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

I think these should be the only modules not needed at startup.

WebappManager.jsm is already loaded lazily in nsBrowserGlue.js (in |_finalUIStartup|).

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Patch

There's also a module imported by ActivitiesService.jsm that isn't needed during startup.

Comment 5

[Marco Castelluccio [:marco]]

The two prefs are basically static, this is why I'm using those to decide whether the modules should be loaded or not.

In particular, I think "dom.webapps.useCurrentProfile" could be replaced by a #ifdef MOZ_B2G.

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Patch

I changed my mind, using defineLazyModuleGetter we don't load those modules when not needed and we still support changing those prefs.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/7d430b6ad970

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d430b6ad970