Closed Bug 986533 Opened 10 years ago Closed 10 years ago

Loop Server — generation of the token should ask for a caller identifier.

Categories

(Hello (Loop) :: Server, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: rhubscher)

References

Details

Attachments

(1 file)

55 bytes, text/x-github-pull-request
alexis+bugs
: review+
Details | Review
We should ask the user to provide a callerId parameter, and store it in the token.
Assignee: nobody → rhubscher
Attached file Link to GitHub PR.
Attachment #8395616 - Flags: review?(alexis+bugs)
Status: NEW → ASSIGNED
Comment on attachment 8395616 [details] [review]
Link to GitHub PR.

r+, please update the other tests to reflect the fact we're adding a new field in the tokens.

(hint: maybe that could make sense to have a helper to generate the tokens for the tests?)
Attachment #8395616 - Flags: review?(alexis+bugs) → review+
https://github.com/mozilla-services/loop-server/commit/f60aa75f43ad9867656f56a88355c31c27ac06c7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 987597
Does this need automated or manual testing?
Flags: needinfo?(alexis+bugs)
QA Contact: jbonacci
Looks like it's well covered by unit testing. Not sure that any additional testing is needed.
:alexis - can you provide some details?
Also - does this require any changes to the load test?
Whiteboard: [qa?]
This is tested in functional tests and in the load tests, yes. No more manual testing is required for this.
Flags: needinfo?(alexis+bugs)
OK. Verified in code, and in functional and load tests.
Status: RESOLVED → VERIFIED
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: