Closed
Bug 986533
Opened 11 years ago
Closed 11 years ago
Loop Server — generation of the token should ask for a caller identifier.
Categories
(Hello (Loop) :: Server, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: alexis+bugs, Assigned: rhubscher)
References
Details
Attachments
(1 file)
We should ask the user to provide a callerId parameter, and store it in the token.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → rhubscher
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8395616 -
Flags: review?(alexis+bugs)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8395616 [details] [review]
Link to GitHub PR.
r+, please update the other tests to reflect the fact we're adding a new field in the tokens.
(hint: maybe that could make sense to have a helper to generate the tokens for the tests?)
Attachment #8395616 -
Flags: review?(alexis+bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Does this need automated or manual testing?
Flags: needinfo?(alexis+bugs)
QA Contact: jbonacci
|
||
Comment 5•10 years ago
|
||
Looks like it's well covered by unit testing. Not sure that any additional testing is needed.
:alexis - can you provide some details?
Also - does this require any changes to the load test?
|
|
||
Updated•10 years ago
|
Whiteboard: [qa?]
|
|
Reporter | |
Comment 6•10 years ago
|
||
This is tested in functional tests and in the load tests, yes. No more manual testing is required for this.
Flags: needinfo?(alexis+bugs)
|
|
||
Comment 7•10 years ago
|
||
OK. Verified in code, and in functional and load tests.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•