Closed
Bug 987597
Opened 11 years ago
Closed 11 years ago
Adapt desktop client to send an identifier when obtaining a call-url
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
| backlog | mlp+ |
People
(Reporter: standard8, Assigned: rgauthier)
References
Details
(Whiteboard: [landed on loop-ui-initial][s=mlpnightly1, p=.25])
User Story
Approximate UX: - Open panel - Enter a nickname - Click the get-url button
Attachments
(1 file)
Following bug 986533 and various discussions, we need the link generator to specify a name/id for the link, so that the user knows who's calling them when they receive a call.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → standard8
User Story: (updated)
|
Assignee | |
Updated•11 years ago
|
Assignee: standard8 → rgauthier
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8396416 -
Flags: review?(standard8)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8396416 [details] [review]
Send an caller identifier when obtaining a call-url
Commented on PR, I think this needs a bit more work before we can land it.
Attachment #8396416 -
Flags: review?(standard8) → review-
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8396416 [details] [review]
Send an caller identifier when obtaining a call-url
Updated patch looks good. r=Standard8 with nits addressed.
Attachment #8396416 -
Flags: review- → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
As we wanted to get this landed and the nits were small, I've addressed them for you, and landed them here:
https://github.com/adamroach/gecko-dev/commit/514a911513348339e71b97b1ee70cc2eae7b5ec1
https://github.com/adamroach/gecko-dev/commit/3cea7d7787bbf56e5a83561cf147cf668614d30c
I've also synced the shared part of the patch with loop-client as we're looking to centralise that directory:
https://github.com/mozilla/loop-client/commit/25935ae812c47f057c898a54fac349e56f5b5aea
Leaving open until this actually lands on m-c.
Whiteboard: [fixed in gecko-dev]
|
|
Reporter | |
Updated•11 years ago
|
Priority: -- → P1
Whiteboard: [fixed in gecko-dev] → [fixed in loop-ui-initial]
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [fixed in loop-ui-initial] → [landed on loop-ui-initial]
|
||
Updated•11 years ago
|
backlog: --- → mlp+
|
|
Reporter | |
Comment 5•11 years ago
|
||
Marking fixed as this has landed on loop-ui-initial and we believe the work here is done; loop-ui-initial will be cherry-picked to master at an appropriate time.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [landed on loop-ui-initial] → [landed on loop-ui-initial][s=mlpnightly1, p=.25]
|
|
Reporter | |
Comment 6•11 years ago
|
||
|
|
Reporter | |
Comment 7•11 years ago
|
||
|
|
Reporter | |
Updated•11 years ago
|
Target Milestone: --- → mozilla33
|
||
Comment 8•11 years ago
|
||
Please use meaningful string ids in the future.
Looks like this landed with tests. Does this need QA testing?
QA Contact: anthony.s.hughes
Whiteboard: [landed on loop-ui-initial][s=mlpnightly1, p=.25] → [landed on loop-ui-initial][s=mlpnightly1, p=.25][qa?]
Flags: qe-verify-
Whiteboard: [landed on loop-ui-initial][s=mlpnightly1, p=.25][qa?] → [landed on loop-ui-initial][s=mlpnightly1, p=.25]
You need to log in
before you can comment on or make changes to this bug.
Description
•